Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

    • -24
    • +24
    ./referencedata/validate/OrderableValidatorTest.java
  1. … 6 more files in changeset.
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

    • -24
    • +24
    ./referencedata/validate/OrderableValidatorTest.java
  1. … 6 more files in changeset.
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

    • -24
    • +24
    ./referencedata/validate/OrderableValidatorTest.java
  1. … 6 more files in changeset.
OLMIS-6726: Added volume and temperature info to Orderables

    • -0
    • +65
    ./referencedata/domain/measurement/TemperatureMeasurementTest.java
    • -0
    • +52
    ./referencedata/testbuilder/TemperatureMeasurementDataBuilder.java
    • -0
    • +49
    ./referencedata/testbuilder/VolumeMeasurementDataBuilder.java
    • -0
    • +152
    ./referencedata/validate/OrderableValidatorTest.java
  1. … 16 more files in changeset.
OLMIS-6726: Added volume and temperature info to Orderables

    • -0
    • +65
    ./referencedata/domain/measurement/TemperatureMeasurementTest.java
    • -0
    • +52
    ./referencedata/testbuilder/TemperatureMeasurementDataBuilder.java
    • -0
    • +49
    ./referencedata/testbuilder/VolumeMeasurementDataBuilder.java
    • -0
    • +152
    ./referencedata/validate/OrderableValidatorTest.java
  1. … 16 more files in changeset.
OLMIS-6726: Added methods to OrderableDataBuilder class, changed access level to fields in BaseMeasurement and Measurement classes

  1. … 8 more files in changeset.
OLMIS-6726: Defined a constant in OrderableMessageKeys, changed validator for volume value

  1. … 4 more files in changeset.
OLMIS-6726: Added missing tests from OrderableValidatorTest and missing annotations

    • -0
    • +21
    ./referencedata/validate/OrderableValidatorTest.java
  1. … 10 more files in changeset.
OLMIS-6726: Added missing tests, dataBuilders, Dto classes for TemperatureMeasurement, VolumeMeasurement, BaseMeasurement and Measurement classes

    • -0
    • +50
    ./referencedata/domain/measurement/TemperatureMeasurementTest.java
    • -0
    • +52
    ./referencedata/testbuilder/TemperatureMeasurementDataBuilder.java
    • -0
    • +49
    ./referencedata/testbuilder/VolumeMeasurementDataBuilder.java
    • -41
    • +18
    ./referencedata/validate/OrderableValidatorTest.java
  1. … 12 more files in changeset.
OLMIS-6726: Added volume and temperature info to Orderables

    • -0
    • +150
    ./referencedata/validate/OrderableValidatorTest.java
  1. … 13 more files in changeset.
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint...
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint...
OLMIS-6676: Fixed checkstyle issue

OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint in the database.

  1. … 6 more files in changeset.
Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

True. The method was refactored.

True. The method was refactored.

Why do we need this step if we are returning null anyways?

Why do we need this step if we are returning null anyways?

Yes. I changed it to make sure it returns GMT. Note: when testing the api with Postman Last-Modified header was set with GMT.

Yes. I changed it to make sure it returns GMT. Note: when testing the api with Postman Last-Modified header was set with GMT.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

Working on it. JPQL does not support LIMIT I think so I am looking into Pageable. EDIT: So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

Working on it. JPQL does not support LIMIT I think so I am looking into Pageable.
EDIT: So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

OLMIS-6611: Refactored to use GMT and removed one profiler

  1. … 5 more files in changeset.
That is not correct. Last-Modified and If-Modified-Since headers should always use GMT: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/d...
This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT: "HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/...

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT:
"HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since