Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6614: Improved test coverage

  1. … 3 more files in changeset.
OLMIS-6614: Added serving of facilityId and programId params and reduced number of queries to DB made by `GET /api/orderableFulfills` endpoint

    • -0
    • +100
    ./openlmis/referencedata/web/OrderableFulfillSearchParamsTest.java
  1. … 12 more files in changeset.
OLMIS-6614: Updated api-definition

  1. … 1 more file in changeset.
OLMIS-6614: Added serving of facilityId and programId params and reduced number of queries to DB made by `GET /api/orderableFulfills` endpoint

    • -0
    • +100
    ./openlmis/referencedata/web/OrderableFulfillSearchParamsTest.java
  1. … 8 more files in changeset.
OLMIS-6470: Added validation for creating ReqGroup with already assigned SupNode + refactored SupervisoryNodeController + added error messages

  1. … 6 more files in changeset.
We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

Please remove one of those changelogs (or merge them somehow).

Please remove one of those changelogs (or merge them somehow).

Extracting those lines to a separate method will cause "The class has too many methods, consider refactoring it" error while building project in Gradle.

Extracting those lines to a separate method will cause "The class has too many methods, consider refactoring it" error while building project in Gradle.

OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup
OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup
Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am no...

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am not mistaken. The SN presence is validated before that and is indeed throwing ValidationMessageExeption if needed. Maybe I should just correct the log message as it's indeed confusing now?

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
OLMIS-6528 Fixed Internal Server Error after searching for orderables with null or malformed id
OLMIS-6528 Fixed Internal Server Error after searching for orderables with null or malformed id
OLMIS-6528 Fixed Internal Server Error after searching for orderables with null or malformed id

  1. … 6 more files in changeset.
OLMIS-6470: Fixed creating and updating Supervisory Node without Requisition Group and added validation.

  1. … 3 more files in changeset.
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name

  1. … 4 more files in changeset.