20180709205313168__add_extradata_to_processing_periods.sql

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thanks very much for the explanation! I didn't notice the class-level Getter annotation.

Thanks very much for the explanation! I didn't notice the class-level Getter annotation.

Done.

Done.

Done.

Done.

I copied it from another part of the UI code that shows a checkmark icon.

I copied it from another part of the UI code that shows a checkmark icon.

Correct. If you see the full file context, you will see a Getter annotation on the class, which means that Lombok auto-generates a get method on this property. That get method is what Jackson uses ...

Correct. If you see the full file context, you will see a Getter annotation on the class, which means that Lombok auto-generates a get method on this property. That get method is what Jackson uses to serialize this DTO into a JSON object for the API response. Definitely seems "magicky".

I think that this field is used in getters for this class which are generated using Lombok and used by Jackson. Then it will be used on the UI extracted from response (processing-schedule-edit.html)

I think that this field is used in getters for this class which are generated using Lombok and used by Jackson. Then it will be used on the UI extracted from response (processing-schedule-edit.html)

I might just be showing my ignorance in how this class is used, but what is the point of adding a private member with no usages?

I might just be showing my ignorance in how this class is used, but what is the point of adding a private member with no usages?

Would we make this class express state? In SMACSS-ish way it should be "is-report-only".

Would we make this class express state? In SMACSS-ish way it should be "is-report-only".

That's correct.

That's correct.

I think that if this for is not inline anymore we don't need those <div class="form-group"> around label+input, right Nikodem Graczewski?

I think that if this for is not inline anymore we don't need those <div class="form-group"> around label+input, right Nikodem Graczewski?

Incorrect HTML; same below.

Incorrect HTML; same below.

Made this form not inline because it looked strange as an inline form.

Made this form not inline because it looked strange as an inline form.

OLMIS-4980 Add report only flag to processing period
OLMIS-4980 Add report only flag to processing period
OLMIS-4980 Add extra data to processing period

This supports showing extra data (for "report only" property) for processing period.

    • -0
    • +1
    ./20180709205313168__add_extradata_to_processing_periods.sql
  1. … 3 more files in changeset.