Lines of code count not available
Added a couple of comments.
I added a comment there, but we should change those methods in the DTO to use all properties returned by the DTO. This is because, as we are ETagging responses, if anything changes in the ProcessingScheduleDto (even the description), we should return a different ETag/hash.
Okay, so this looks like tech debt, where for this DTO, we are determining equality by code only. For DTOs, we should do it by all properties we are returning, including the id in the BaseDto.
because it's designed value object that shoud be used
Why? we have mulitple codes but we are using it only in Program I think
use Code class
Use Code class, it has already equals with ignore case
I will refactor equals and hasCode methods but should I change them in dto class as well? also those methods use code only, should I include name also?
I think we Chongsun Ahn especially have dto in mind since they will be used with ETag
Since we are saying that processing schedule codes and names are case insensitive, can we re-implement equals and hashCode to reflect that? For code, we can use our Code class.
why this change?
Got a suggestion or an issue?
Discuss it on Atlassian Answers or
visit Atlassian Support for other options.