20170727223510722__create_index_on_right_assignments_userid_rightname.sql

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Ah, okay. I get it now. The endpoint still needs to expend cycles getting and generating the etag, so that it may know if it can return a 304 or not. So we save network bandwidth, but not server ti...

Ah, okay. I get it now. The endpoint still needs to expend cycles getting and generating the etag, so that it may know if it can return a 304 or not. So we save network bandwidth, but not server time. It wasn't what I was thinking when I wrote the AC, but given the server time expended on this endpoint I think it works. Lets be on the lookout for a place where establishing a 304 where we could also save server time as well would be worthwhile.

Done. It is added to the review.

Done. It is added to the review.

I was trying to yesterday, but FishEye was being unresponsive. Added it now.

I was trying to yesterday, but FishEye was being unresponsive. Added it now.

Actually the 304 Not Modified and HEAD operations are supported, but they weren't in this review, but in FEOLMIS-1741. If you look at the Java code in the controller for this endpoint, in the Respo...

Actually the 304 Not Modified and HEAD operations are supported, but they weren't in this review, but in FEOLMIS-1741. If you look at the Java code in the controller for this endpoint, in the ResponseEntity I return an ETag value. Using that ETag value in a HEAD operation or a GET operation using If-None-Match, will return a 304.

One more thing I think we should improve: lets add what the format of a permission string is to the API docs.

One more thing I think we should improve: lets add what the format of a permission string is to the API docs.

Are you still thinking about adding the indexes on user, right, etc?

Are you still thinking about adding the indexes on user, right, etc?

Something I just noticed is that while you generate the permission strings with a 200, you're not supporting the 304 - Not Modified, nor supporting the HEAD operation. I'd like to start establishin...

Something I just noticed is that while you generate the permission strings with a 200, you're not supporting the 304 - Not Modified, nor supporting the HEAD operation. I'd like to start establishing what our patterns are for those which is chiefly why they're in the AC.

OLMIS-2811 OLMIS-2885 Create index on right assignments table

To improve performance.

    • -0
    • +1
    ./20170727223510722__create_index_on_right_assignments_userid_rightname.sql
OLMIS-2811 OLMIS-2885 Improve performance of permissionStrings endpoint
OLMIS-2811 OLMIS-2885 Improve performance of permissionStrings endpoint