20170206205310272__initial_bootstrap_data.sql

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
lgtm

lgtm

I still wanted to all those tests to use the same methods, and some of them are creating new multiple types.

I still wanted to all those tests to use the same methods, and some of them are creating new multiple types.

why not generate one in setUp and use field for FacilityType?

why not generate one in setUp and use field for FacilityType?

This is to prevent saving warehouse facility type, because there is one already

This is to prevent saving warehouse facility type, because there is one already

Delete should probably be very rare - and should rather not impact user data.

Delete should probably be very rare - and should rather not impact user data.

Depends - but not sure why we would do this here? What is the impact on facilities? What are we trying to achieve here?

Depends - but not sure why we would do this here? What is the impact on facilities? What are we trying to achieve here?

I'm not sure what is the purpose these lines?

I'm not sure what is the purpose these lines?

Paweł Gesek do you think that is acceptable to delete sth in migrations?

Paweł Gesek do you think that is acceptable to delete sth in migrations?

OLMIS-2492: created new migration and fixed some tests

    • -1
    • +1
    ./20170206205310272__initial_bootstrap_data.sql
  1. … 4 more files in changeset.
initial bootstrap shouldn't be changed

initial bootstrap shouldn't be changed

if we extracted private method I think we can use it for these 5 lines as well

if we extracted private method I think we can use it for these 5 lines as well

OLMIS-2492: moved warehouse facility type to initial data

    • -1
    • +1
    ./20170206205310272__initial_bootstrap_data.sql
  1. … 3 more files in changeset.
space after code

space after code

OLMIS-2492: added facility type param to facility search endpoint
OLMIS-2492: added facility type param to facility search endpoint
[stock permissions] change right name of ORGANIZATIONS_MANAGE to STOCK_ORGANIZATIONS_MANAGE

    • -1
    • +1
    ./20170206205310272__initial_bootstrap_data.sql
[stock permissions] remove stock card line item reasons view right, anyone who is logged in can see reasons

    • -2
    • +0
    ./20170206205310272__initial_bootstrap_data.sql
[stock permissions] remove stock destinations view right, anyone who is logged in can see destinations

    • -2
    • +0
    ./20170206205310272__initial_bootstrap_data.sql
[stock permissions] 1 remove stock events create right. users can have stock adjust or stock physical inventory edit rights instead. 2 remove STOCK_SOURCES_VIEW right, anyone who is logged in can see sources

    • -3
    • +0
    ./20170206205310272__initial_bootstrap_data.sql
  1. … 1 more file in changeset.
[stock permissions] add new right STOCK_CARDS_VIEW, and put it in stock manager role.

    • -1
    • +1
    ./20170206205310272__initial_bootstrap_data.sql
  1. … 1 more file in changeset.
[stock permissions] fix typo in uuid

    • -1
    • +1
    ./20170206205310272__initial_bootstrap_data.sql
  1. … 1 more file in changeset.
[stock permissions] add new right STOCK_ADJUST, and put it in stock manager role.

    • -0
    • +1
    ./20170206205310272__initial_bootstrap_data.sql
  1. … 1 more file in changeset.
[stock permissions] add new right STOCK_INVENTORIES_EDIT, and put it in stock manager role.

    • -0
    • +1
    ./20170206205310272__initial_bootstrap_data.sql
  1. … 1 more file in changeset.
OLMIS-632 create a right for stock destinations management and assign to admin

    • -0
    • +2
    ./20170206205310272__initial_bootstrap_data.sql
OLMIS-633 create a right for stock sources management and assign to admin

    • -0
    • +2
    ./20170206205310272__initial_bootstrap_data.sql
OLMIS-632 add new right to admin to manage organizations

    • -0
    • +2
    ./20170206205310272__initial_bootstrap_data.sql
OLMIS-629 add new right for admin to manage stock reasons

    • -0
    • +2
    ./20170206205310272__initial_bootstrap_data.sql
OLMIS-1440 fix typo, destination to destinations

    • -1
    • +1
    ./20170206205310272__initial_bootstrap_data.sql
OLMIS-1440 add rights of viewing stock sources, destinations and reasons, and give them to the admin role(admin need to see all sources/destinations/reasons).

    • -3
    • +3
    ./20170206205310272__initial_bootstrap_data.sql