Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5622: Update demo data README.md

OLMIS-5354: Added right to System Admin role

Okay so now: *administrator has the ability to go through the requisition workflow for the new program *srmanager1 can create and submit a requisition for the new program *smanager1 can authoriz...

Okay so now:

  • administrator has the ability to go through the requisition workflow for the new program
  • srmanager1 can create and submit a requisition for the new program
  • smanager1 can authorize the requisition
  • psupervisor can approve the 'regular' requisition
  • chaz can approve the 'splitted' requisition
I would prefer there be a separate user for the 'regular' requisition workflow. It would be better for demoing since there would be separate users in actual usage in Zambia.

I would prefer there be a separate user for the 'regular' requisition workflow. It would be better for demoing since there would be separate users in actual usage in Zambia.

this is a req group for chaz SN and contains the same facilities as the regular one.

this is a req group for chaz SN and contains the same facilities as the regular one.

so chaz user has all rights required to go through the regular requisition workflow and to manage splitted requisitions. In other words after the split chaz user will be able to see a 'regular' req...

so chaz user has all rights required to go through the regular requisition workflow and to manage splitted requisitions. In other words after the split chaz user will be able to see a 'regular' requisition and a 'splitted' requisition.

changed

changed

Looks pretty good, just one comment.

Looks pretty good, just one comment.

We should leave this as CHAZ, since CHAZ is the actual supply partner, and it could be associated with multiple programs. Nevermind, I see the latest code has this.

We should leave this as CHAZ, since CHAZ is the actual supply partner, and it could be associated with multiple programs. Nevermind, I see the latest code has this.

Where is the regular user for the regular workflow? I would think the CHAZ user would simply be handling the approval process on the CHAZ supervisory node.

Where is the regular user for the regular workflow? I would think the CHAZ user would simply be handling the approval process on the CHAZ supervisory node.

It's natural that adding more data will make things take longer. It may be on the order of seconds, but those are extra seconds each time, which adds up. Of course, we want to have enough demo data...

It's natural that adding more data will make things take longer. It may be on the order of seconds, but those are extra seconds each time, which adds up. Of course, we want to have enough demo data to match our non-functional requirements, but if we are adding more than the requirement (10,000 products), we are adding time, particularly developer time.

I'm not going to insist on this, but this is my argument on why I think we should use the existing data.

I think in order to demo requisition splitting, we'll need at least a regular district node and a CHAZ partner node. Nevermind, I see two nodes in latest code.

I think in order to demo requisition splitting, we'll need at least a regular district node and a CHAZ partner node. Nevermind, I see two nodes in latest code.

For the name, we should write it out (Antiretroviral) vs. have an acronym.

For the name, we should write it out (Antiretroviral) vs. have an acronym.

Nevermind I see the other review.

Nevermind I see the other review.

Are these actual facilities in Balaka/Southern Region in Malawi? If they are in Zambia, we should rename them, as it could potentially be a problem in demoing to show Zambia facilities in Malawi.

Are these actual facilities in Balaka/Southern Region in Malawi? If they are in Zambia, we should rename them, as it could potentially be a problem in demoing to show Zambia facilities in Malawi.

OLMIS-5622: Added missing role assignment for CHAZ SN

  1. … 1 more file in changeset.
OLMIS-5622: Added missing role assignment for CHAZ SN

  1. … 1 more file in changeset.
I think now it should be correct. We have one SN which has one partner node. This node has a supply partner association. Quite possible that we would need to extend our GET /api/supplyPartners endp...

I think now it should be correct. We have one SN which has one partner node. This node has a supply partner association. Quite possible that we would need to extend our GET /api/supplyPartners endpoint to able to retrieve supply partners by supervisory node id but this should be done in separate ticket or when we will introduce the feature in the requisition service.

OLMIS-5622: Modified supply partner

  1. … 5 more files in changeset.
OLMIS-5622: Modified supply partner

  1. … 5 more files in changeset.
I renamed them to be more real. I have taken names from the wiki page

I renamed them to be more real. I have taken names from the wiki page