Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6402: Renamed versionId to versionNumber in referencedata
OLMIS-6402: Renamed versionId to versionNumber in referencedata
OLMIS-6402: Renamed versionId field to versionNumber

    • -1
    • +1
    ./referencedata.facility_type_approved_products.csv
    • -1
    • +1
    ./referencedata.orderable_identifiers.csv
    • -1
    • +1
    ./referencedata.program_orderables.csv
    • -1
    • +1
    ./referencedata.supply_partner_association_orderables.csv
  1. … 39 more files in changeset.
OLMIS-6164 removed two redundant ftaps from demo data

    • -2
    • +0
    ./referencedata.facility_type_approved_products.csv
OLMIS-6414 fixed duplicate key violation

    • -4
    • +4
    ./referencedata.facility_type_approved_products.csv
OLMIS-6414 added missing FTAPs to demo data

    • -0
    • +5
    ./referencedata.facility_type_approved_products.csv
  1. … 1 more file in changeset.
I have restored all of products names and codes for those we use in functional tests. http://build.openlmis.org/job/OpenLMIS-functional-tests/2307/

I have restored all of products names and codes for those we use in functional tests. http://build.openlmis.org/job/OpenLMIS-functional-tests/2307/

OLMIS-6363 Restore more product names and codes for functional tests.

OLMIS-6363 Restore a few product names and codes for func tests.

Probably functional tests will fail because of missing orderables like ARV0001, Male Condom, IPV - 5 dose,injection and some other. You can find them here: https://github.com/OpenLMIS/openlmis-func...

Probably functional tests will fail because of missing orderables like ARV0001, Male Condom, IPV - 5 dose,injection and some other. You can find them here: https://github.com/OpenLMIS/openlmis-functional-tests/search?l=Gherkin&q=product. I'm not sure what should we do - adjust tests or restore those orderables.

I have not changed products that have a connection to commodity types or trade items. I have tried to not change products we use for testing but I will ask our QA's to check this.

I have not changed products that have a connection to commodity types or trade items. I have tried to not change products we use for testing but I will ask our QA's to check this.

OLMIS-6363 Update product names and codes for demo data to be more meaningful.
OLMIS-6363 Update product names and codes for demo data to be more meaningful.
OLMIS-6363 Update product names and codes for demo data to be more meaningful.

    • -10075
    • +10075
    ./referencedata.orderables.csv
  1. … 1 more file in changeset.
removed

removed

Yes. The table can contain a lot of data so adding columns and set default values could drop performance

Yes. The table can contain a lot of data so adding columns and set default values could drop performance

Is it because dropping and recreating is faster?

Is it because dropping and recreating is faster?

I don't think we should be settings this in the constructor. I might want to use this constructor in retrieval endpoints, for example Isn't doing this in PrePersist/Update annotated method enough?

I don't think we should be settings this in the constructor. I might want to use this constructor in retrieval endpoints, for example

Isn't doing this in PrePersist/Update annotated method enough?

OLMIS-6358: Added versioning to Facility Type Approved Product resource
OLMIS-6358: Added versioning to Facility Type Approved Product resource
In the following review, I only added a new field to the FTAP resource. I will adjust endpoints in next commits and reviews. Stay tuned.

In the following review, I only added a new field to the FTAP resource. I will adjust endpoints in next commits and reviews. Stay tuned.

OLMIS-6358: Added versioning to Facility Type Approved Product resource

    • -20091
    • +20091
    ./referencedata.facility_type_approved_products.csv
  1. … 21 more files in changeset.
Ok, I will fix it

Ok, I will fix it