Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6658 Cleaned some code

  1. … 5 more files in changeset.
Unfortunately according to the documentation, CriteriaBuilder API doesn't support equals with ignore case

Unfortunately according to the documentation, CriteriaBuilder API doesn't support equals with ignore case

Yes, we can! https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/biggrin.gif

Yes, we can!

Can't we use the constant from the abstract class?

Can't we use the constant from the abstract class?

This is needed for yet another partition in retrieving FTAPs (line 146)

This is needed for yet another partition in retrieving FTAPs (line 146)

We should extract all of those literals as constants

We should extract all of those literals as constants

Also, +1 for splitting the common code to a separate class. Good job!

Also, +1 for splitting the common code to a separate class. Good job!

Instead of this essay can just say "Active flag of ProgramOrderables does no longer impact FTAP endpoints"

Instead of this essay can just say "Active flag of ProgramOrderables does no longer impact FTAP endpoints"

Don't mention requisitions in referencedata

Don't mention requisitions in referencedata

Drop "or not"

Drop "or not"

Can't we request a specific version?

Can't we request a specific version?

drop "or not"

drop "or not"

Why keep it here if we have that in the abstract class already?

Why keep it here if we have that in the abstract class already?

Let's not call this a util class if it's abstract. I'd go with IdentitiesSearchableRepository perhaps?

Let's not call this a util class if it's abstract. I'd go with IdentitiesSearchableRepository perhaps?

Doesn't criteria builder offer equals with ignore case? That would make the code a little easier to read

Doesn't criteria builder offer equals with ignore case? That would make the code a little easier to read

Changelog reminder.

Changelog reminder.

OLMIS-6658 Removed joins checking if programOrderable for Ftap's program is active in order to improve...
OLMIS-6658 Removed joins checking if programOrderable for Ftap's program is active in order to improve...
OLMIS-6658 Removed joins checking if programOrderable for Ftap's program is active in order to improve performance of FTAP search query

  1. … 2 more files in changeset.
OLMIS-6614: Added serving of facilityId and programId params and reduced number of queries to DB made by `GET /api/orderableFulfills` endpoint

  1. … 13 more files in changeset.
OLMIS-6614: Added missing messages

OLMIS-6614: Extended description of parameters in api-definition

OLMIS-6614: Updated api-definition

  1. … 1 more file in changeset.
OLMIS-6470: Added validation for creating ReqGroup with already assigned SupNode + refactored SupervisoryNodeController + added error messages

  1. … 6 more files in changeset.
OLMIS-6568 Fix file.format.incorrect message key in messages_en.

We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");