Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6402: Renamed versionId to versionNumber in referencedata
OLMIS-6402: Renamed versionId to versionNumber in referencedata
OLMIS-6402: Renamed versionId field to versionNumber

  1. … 43 more files in changeset.
Yes, we do: 1) duplication: https://github.com/OpenLMIS/openlmis-referencedata/blob/master/src/integration-test/java/org/openlmis/referencedata/repository/FacilityTypeApprovedProductRepositoryInte...
Do we have a test for duplicated ftap?

Do we have a test for duplicated ftap?

handled by unique index on the database layer

handled by unique index on the database layer

handled by trigger

handled by trigger

OLMIS-6358: Adjusted create endpoint
OLMIS-6358: Adjusted create endpoint
OLMIS-6358: Adjusted create endpoint

  1. … 7 more files in changeset.
OLMIS-6351: Dropped reference to orderable version from FTAP
OLMIS-6351: Dropped reference to orderable version from FTAP
OLMIS-6351: Dropped reference to orderable version from FTAP

  1. … 20 more files in changeset.
OLMIS-5850: updated role name has to be uniq message

  1. … 2 more files in changeset.
Łukasz Lewczyński I have added already, Please check again.

Łukasz Lewczyński I have added already, Please check again.

OLMIS-5850 : Fixed the role name to be unique when different casing is used
OLMIS-5850 : Fixed the role name to be unique when different casing is used
Please change case for this role name. Currently, this test only verifies that two roles with exactly the same name cannot be created.

Please change case for this role name. Currently, this test only verifies that two roles with exactly the same name cannot be created.

I have added the new test code for this issue

I have added the new test code for this issue

Ok I get your point ....let me do that. Thanks

Ok I get your point ....let me do that. Thanks

I still don't see IT that verify that two roles with the same name but different cases cannot be saved to the database something like: @Test(expected = PersistenceException.class) public void s...

I still don't see IT that verify that two roles with the same name but different cases cannot be saved to the database something like:

  @Test(expected = PersistenceException.class)
  public void shouldNotAllowDuplicates() {
    Code productCode = Code.code("test_product_code");

    Orderable orderable1 = generateInstance(productCode);
    Orderable orderable2 = generateInstance(productCode);

    repository.save(orderable1);
    repository.save(orderable2);

    entityManager.flush();
  }
I have added the test and Integration test has to build successfully.

I have added the test and Integration test has to build successfully.