Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

  1. … 7 more files in changeset.
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

  1. … 7 more files in changeset.
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

  1. … 7 more files in changeset.
OLMIS-6726: moved field up in BaseMeasurement class to fix failed quality gate

  1. … 1 more file in changeset.
OLMIS-6726: moved field up in BaseMeasurement class to fix failed quality gate

OLMIS-6726: Added volume and temperature info to Orderables

    • -0
    • +56
    ./measurement/BaseMeasurement.java
    • -0
    • +55
    ./measurement/Measurement.java
    • -0
    • +92
    ./measurement/TemperatureMeasurement.java
    • -0
    • +22
    ./measurement/TemperatureUnitCode.java
    • -0
    • +83
    ./measurement/VolumeMeasurement.java
    • -0
    • +22
    ./measurement/VolumeUnitCode.java
  1. … 15 more files in changeset.
OLMIS-6726: Added volume and temperature info to Orderables

    • -0
    • +56
    ./measurement/BaseMeasurement.java
    • -0
    • +55
    ./measurement/Measurement.java
    • -0
    • +92
    ./measurement/TemperatureMeasurement.java
    • -0
    • +22
    ./measurement/TemperatureUnitCode.java
    • -0
    • +83
    ./measurement/VolumeMeasurement.java
    • -0
    • +22
    ./measurement/VolumeUnitCode.java
  1. … 15 more files in changeset.
OLMIS-6726: Changed parameter name

    • -1
    • +1
    ./measurement/TemperatureMeasurement.java
OLMIS-6726: Added methods to OrderableDataBuilder class, changed access level to fields in BaseMeasurement and Measurement classes

    • -3
    • +5
    ./measurement/TemperatureMeasurement.java
    • -5
    • +10
    ./measurement/VolumeMeasurement.java
  1. … 6 more files in changeset.
OLMIS-6726: Defined a constant in OrderableMessageKeys, changed validator for volume value

    • -1
    • +1
    ./measurement/TemperatureMeasurement.java
  1. … 4 more files in changeset.
OLMIS-6726: Added missing tests from OrderableValidatorTest and missing annotations

    • -6
    • +8
    ./measurement/TemperatureMeasurement.java
  1. … 9 more files in changeset.
OLMIS-6726: Added missing tests, dataBuilders, Dto classes for TemperatureMeasurement, VolumeMeasurement, BaseMeasurement and Measurement classes

    • -2
    • +42
    ./measurement/TemperatureMeasurement.java
    • -1
    • +3
    ./measurement/TemperatureUnitCode.java
    • -0
    • +32
    ./measurement/VolumeMeasurement.java
  1. … 11 more files in changeset.
OLMIS-6726: Added volume and temperature info to Orderables

    • -0
    • +40
    ./measurement/BaseMeasurement.java
    • -0
    • +38
    ./measurement/Measurement.java
    • -0
    • +48
    ./measurement/TemperatureMeasurement.java
    • -0
    • +20
    ./measurement/TemperatureUnitCode.java
    • -0
    • +45
    ./measurement/VolumeMeasurement.java
    • -0
    • +20
    ./measurement/VolumeUnitCode.java
  1. … 7 more files in changeset.
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint...
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint...
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint in the database.

  1. … 6 more files in changeset.
It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

Is that still necessary?

Is that still necessary?

We should be using constants for all of the literals

We should be using constants for all of the literals

OLMIS-6675: Added entity graph for Orderable with javax.persistence.loadgraph hint

  1. … 1 more file in changeset.
What about changelog? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

What about changelog?

OLMIS-6566: Updated orderable search query
OLMIS-6566: Updated orderable search query
OLMIS-6566: Refactored searching for orderables to use JPQL instead of native queries Also removed entity graph because it did not help with n+1 problem

  1. … 2 more files in changeset.
OLMIS-6566: Added entity graph for Orderable

  1. … 1 more file in changeset.