Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes

Updating a resource should never introduce any changes in another resource other than

relationships between them. Requisition Groups update allowed changes to supervisory nodes,

morever those changes were only partial (child nodes were always cut off). This was fixed

and the RG update only allows switching the SN to another one now.

    • -12
    • +3
    ./referencedata/web/RequisitionGroupController.java
  1. … 1 more file in changeset.
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

    • -20
    • +20
    ./referencedata/domain/Orderable.java
    • -20
    • +18
    ./referencedata/dto/OrderableDto.java
    • -39
    • +39
    ./referencedata/validate/OrderableValidator.java
  1. … 4 more files in changeset.
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

    • -20
    • +20
    ./referencedata/domain/Orderable.java
    • -20
    • +18
    ./referencedata/dto/OrderableDto.java
    • -39
    • +39
    ./referencedata/validate/OrderableValidator.java
  1. … 4 more files in changeset.
OLMIS-6739: Renamed the minimum/maximumToleranceTemperature variables

    • -20
    • +20
    ./referencedata/domain/Orderable.java
    • -20
    • +18
    ./referencedata/dto/OrderableDto.java
    • -39
    • +39
    ./referencedata/validate/OrderableValidator.java
  1. … 4 more files in changeset.
OLMIS-6726: moved field up in BaseMeasurement class to fix failed quality gate

  1. … 1 more file in changeset.
OLMIS-6726: moved field up in BaseMeasurement class to fix failed quality gate

OLMIS-6726: Added volume and temperature info to Orderables

    • -1
    • +72
    ./referencedata/domain/Orderable.java
    • -0
    • +56
    ./referencedata/domain/measurement/BaseMeasurement.java
    • -0
    • +55
    ./referencedata/domain/measurement/Measurement.java
    • -0
    • +22
    ./referencedata/domain/measurement/TemperatureUnitCode.java
    • -0
    • +83
    ./referencedata/domain/measurement/VolumeMeasurement.java
    • -0
    • +22
    ./referencedata/domain/measurement/VolumeUnitCode.java
    • -0
    • +44
    ./referencedata/dto/OrderableDto.java
    • -0
    • +41
    ./referencedata/dto/TemperatureMeasurementDto.java
    • -0
    • +41
    ./referencedata/dto/VolumeMeasurementDto.java
    • -0
    • +142
    ./referencedata/validate/OrderableValidator.java
  1. … 10 more files in changeset.
OLMIS-6726: Added volume and temperature info to Orderables

    • -1
    • +72
    ./referencedata/domain/Orderable.java
    • -0
    • +56
    ./referencedata/domain/measurement/BaseMeasurement.java
    • -0
    • +55
    ./referencedata/domain/measurement/Measurement.java
    • -0
    • +22
    ./referencedata/domain/measurement/TemperatureUnitCode.java
    • -0
    • +83
    ./referencedata/domain/measurement/VolumeMeasurement.java
    • -0
    • +22
    ./referencedata/domain/measurement/VolumeUnitCode.java
    • -0
    • +44
    ./referencedata/dto/OrderableDto.java
    • -0
    • +41
    ./referencedata/dto/TemperatureMeasurementDto.java
    • -0
    • +41
    ./referencedata/dto/VolumeMeasurementDto.java
    • -0
    • +142
    ./referencedata/validate/OrderableValidator.java
  1. … 10 more files in changeset.
OLMIS-6726: Changed parameter name

OLMIS-6726: Added methods to OrderableDataBuilder class, changed access level to fields in BaseMeasurement and Measurement classes

    • -0
    • +17
    ./referencedata/dto/OrderableDto.java
    • -3
    • +3
    ./referencedata/dto/TemperatureMeasurementDto.java
    • -3
    • +3
    ./referencedata/dto/VolumeMeasurementDto.java
  1. … 2 more files in changeset.
OLMIS-6726: Defined a constant in OrderableMessageKeys, changed validator for volume value

  1. … 2 more files in changeset.
OLMIS-6726: Added missing tests from OrderableValidatorTest and missing annotations

    • -1
    • +0
    ./referencedata/dto/TemperatureMeasurementDto.java
    • -1
    • +0
    ./referencedata/dto/VolumeMeasurementDto.java
    • -15
    • +57
    ./referencedata/validate/OrderableValidator.java
  1. … 5 more files in changeset.
OLMIS-6726: Added missing tests, dataBuilders, Dto classes for TemperatureMeasurement, VolumeMeasurement, BaseMeasurement and Measurement classes

    • -15
    • +9
    ./referencedata/domain/Orderable.java
    • -29
    • +9
    ./referencedata/dto/OrderableDto.java
    • -0
    • +42
    ./referencedata/dto/TemperatureMeasurementDto.java
    • -0
    • +42
    ./referencedata/dto/VolumeMeasurementDto.java
    • -13
    • +22
    ./referencedata/validate/OrderableValidator.java
  1. … 7 more files in changeset.
OLMIS-6726: Added volume and temperature info to Orderables

    • -1
    • +78
    ./referencedata/domain/Orderable.java
    • -0
    • +40
    ./referencedata/domain/measurement/BaseMeasurement.java
    • -0
    • +38
    ./referencedata/domain/measurement/Measurement.java
    • -0
    • +20
    ./referencedata/domain/measurement/TemperatureUnitCode.java
    • -0
    • +45
    ./referencedata/domain/measurement/VolumeMeasurement.java
    • -0
    • +20
    ./referencedata/domain/measurement/VolumeUnitCode.java
    • -0
    • +47
    ./referencedata/dto/OrderableDto.java
  1. … 4 more files in changeset.
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint...
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint...
OLMIS-6676: Updated lot validator to allow trade items to share lot codes. Also added unique constraint in the database.

    • -3
    • +6
    ./referencedata/validate/LotValidator.java
  1. … 5 more files in changeset.
Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

OLMIS-6611: Removed unnecessary method

    • -10
    • +3
    ./referencedata/web/OrderableController.java
Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?