Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Let's not send another request just to verify the headers. We can re-use response from the previous call.

Let's not send another request just to verify the headers. We can re-use response from the previous call.

Let's not introduce another test just to verify the header. We can do the additional check in existing tests.

Let's not introduce another test just to verify the header. We can do the additional check in existing tests.

OLMIS-6485 Added new test to check Last-Modified Header's presence in PUT /orderables responses and improved exisiting onese

  1. … 2 more files in changeset.
I debugged it and I can confirm that. I removed that line from those tests and I'm looking for new way to test it - either inside those methods or separately.

I debugged it and I can confirm that. I removed that line from those tests and I'm looking for new way to test it - either inside those methods or separately.

Update Changelog file, please.

Update Changelog file, please.

Since you have added profiler - let's add measurements for each important step - validate, build orderable, save,

Since you have added profiler - let's add measurements for each important step - validate, build orderable, save,

This block is repeated 3 times. Extract it to a private method.

This block is repeated 3 times. Extract it to a private method.

This likely has the potential to fail randomly. Please debug this test to verify.

This likely has the potential to fail randomly. Please debug this test to verify.

OLMIS-6485 Added Last-Modified Header to the POST and PUT /orderables endpoints
OLMIS-6485 Added Last-Modified Header to the POST and PUT /orderables endpoints
OLMIS-6485 Added Last-Modified Header to the POST and PUT /orderables endpoints

  1. … 1 more file in changeset.
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name

  1. … 2 more files in changeset.
Working on adding Last-Modified header to Http Responses while creating and updating orderables

  1. … 1 more file in changeset.
OLMIS-6476 Fixed query for finding orderable with latest modified date with pagination

done

done

should we update entries in database after setting last updated field?

should we update entries in database after setting last updated field?

OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables
OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables
OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables

  1. … 4 more files in changeset.
OLMIS-6474: Extracted fetching commodity types and trade items above the loop

* OLMIS-6474: Extracted fetching commodity types and trade items above the loop

* PIMS-6474: Changed the changelog entry

  1. … 3 more files in changeset.
OLMIS-6475 Add support for If-Modified-Since to Get Orderable by ID
OLMIS-6475 Add support for If-Modified-Since to Get Orderable by ID
OLMIS-6475 Add support for If-Modified-Since to Get Orderable by ID

The orderable endpoint that retrieves by ID now supports If-Modified-Since header as per RFC 7232.

Last-Modified header is also included with the response.

  1. … 3 more files in changeset.