Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes
OLMIS-6749 RequisitionGroup update does no longer make any changes to Supervisory Nodes

Updating a resource should never introduce any changes in another resource other than

relationships between them. Requisition Groups update allowed changes to supervisory nodes,

morever those changes were only partial (child nodes were always cut off). This was fixed

and the RG update only allows switching the SN to another one now.

    • -0
    • +6
    ./RequisitionGroupControllerIntegrationTest.java
  1. … 1 more file in changeset.
Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

True. The method was refactored.

True. The method was refactored.

Why do we need this step if we are returning null anyways?

Why do we need this step if we are returning null anyways?

OLMIS-6566: Removed unnecessary method from OrderableRepositoryImpl

    • -17
    • +0
    ./OrderableControllerIntegrationTest.java
  1. … 3 more files in changeset.
It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

It looks like it isn't. Moreover, the whole findOrderablesWithLatestModifiedDate method is unnecessary.

Is that still necessary?

Is that still necessary?

We should be using constants for all of the literals

We should be using constants for all of the literals

What about changelog? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

What about changelog?

OLMIS-6566: Updated orderable search query
OLMIS-6566: Updated orderable search query
Yes. I changed it to make sure it returns GMT. Note: when testing the api with Postman Last-Modified header was set with GMT.

Yes. I changed it to make sure it returns GMT. Note: when testing the api with Postman Last-Modified header was set with GMT.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

Working on it. JPQL does not support LIMIT I think so I am looking into Pageable. EDIT: So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

Working on it. JPQL does not support LIMIT I think so I am looking into Pageable.
EDIT: So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

OLMIS-6611: Refactored to use GMT and removed one profiler

    • -2
    • +2
    ./OrderableControllerIntegrationTest.java
  1. … 5 more files in changeset.
That is not correct. Last-Modified and If-Modified-Since headers should always use GMT: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/d...
This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT: "HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/...

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT:
"HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT: "HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/...

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT:
"HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since

Yes. Of course. Changed it to use count-query.

Yes. Of course. Changed it to use count-query.

I tried, however as there are different objects (MultiValueMap, OrderableSearchParams, QueryOrderableSearchParams, SearchParams) passed as arguments in different methods I wanted to somehow unify i...

I tried, however as there are different objects (MultiValueMap, OrderableSearchParams, QueryOrderableSearchParams, SearchParams) passed as arguments in different methods I wanted to somehow unify it for future data flow. If it could be done in a more simple way I would need a hint.

Changed it to get system default. Also in tests.

Changed it to get system default. Also in tests.