Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am no...

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am not mistaken. The SN presence is validated before that and is indeed throwing ValidationMessageExeption if needed. Maybe I should just correct the log message as it's indeed confusing now?

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}

    • -5
    • +10
    ./RequisitionGroupRepositoryIntegrationTest.java
  1. … 2 more files in changeset.
OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}

    • -5
    • +10
    ./RequisitionGroupRepositoryIntegrationTest.java
  1. … 2 more files in changeset.
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name
OLMIS-6476 Fixed getting paginated orderables and added sorting by product name

    • -1
    • +45
    ./OrderableRepositoryIntegrationTest.java
  1. … 4 more files in changeset.
done

done

OLMIS-6476 Improved integration tests for orderable repository

    • -0
    • +9
    ./OrderableRepositoryIntegrationTest.java
should we update entries in database after setting last updated field?

should we update entries in database after setting last updated field?

OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables
OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables
OLMIS-6476 Added support for If-Modified-Since header to get and search Orderables

    • -1
    • +63
    ./OrderableRepositoryIntegrationTest.java
  1. … 10 more files in changeset.
OLMIS-6463; Added searching ftaps by orderableId
OLMIS-6463; Added searching ftaps by orderableId
OLMIS-6463; Added searching ftaps by orderableId

    • -0
    • +20
    ./FacilityTypeApprovedProductRepositoryIntegrationTest.java
  1. … 11 more files in changeset.
OLMIS-6402: Renamed versionId to versionNumber in referencedata
OLMIS-6402: Renamed versionId to versionNumber in referencedata