Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Right. Changed it https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Right. Changed it

Since we have released version 14.0.0, it should be 14.0.1 now (look at the service version in gradle.properties).

Since we have released version 14.0.0, it should be 14.0.1 now (look at the service version in gradle.properties).

OLMIS-6575: Fixed Internal Server Error for /supervisoryNodes endpoint
OLMIS-6575: Fixed Internal Server Error for /supervisoryNodes endpoint
OLMIS-6575: Fixed Internal Server Error for /supervisoryNodes endpoint

  1. … 3 more files in changeset.
OLMIS-6614: Added serving of facilityId and programId params and reduced number of queries to DB made by `GET /api/orderableFulfills` endpoint

    • -11
    • +70
    ./openlmis/referencedata/web/OrderableFulfillControllerIntegrationTest.java
  1. … 14 more files in changeset.
OLMIS-6614: Fixed tests & added changelog

    • -11
    • +70
    ./openlmis/referencedata/web/OrderableFulfillControllerIntegrationTest.java
  1. … 2 more files in changeset.
We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

We can just ignore this error by: @SuppressWarnings("PMD.TooManyMethods");

Please remove one of those changelogs (or merge them somehow).

Please remove one of those changelogs (or merge them somehow).

Extracting those lines to a separate method will cause "The class has too many methods, consider refactoring it" error while building project in Gradle.

Extracting those lines to a separate method will cause "The class has too many methods, consider refactoring it" error while building project in Gradle.

OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup
OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup
OLMIS-6470: Fixed creating and updating SupervisoryNode with RequisitionGroup

    • -39
    • +136
    ./openlmis/referencedata/web/SupervisoryNodeControllerIntegrationTest.java
  1. … 2 more files in changeset.
Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Ok, throwing exception here is not desired indeed. If we want to log a message, it should be changed to indicate that the Supervisory Node doesn't exist in the database.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

Could we merge those calls? I think we don't need the second one, we can simply return supervisory node object from the line 329.

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am no...

It's not checking whether SN exists in update request, but if a SN with a given id (as in the request) already exists. Throwing exception now may cause more trouble in the app's behavior if I am not mistaken. The SN presence is validated before that and is indeed throwing ValidationMessageExeption if needed. Maybe I should just correct the log message as it's indeed confusing now?

OLMIS-6450 Retrieve last modified date only when needed

This means removing the response header with last modified date in search

and querying for it only when the if-modified-since header was provided

  1. … 1 more file in changeset.
I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

I think we should add this message to MessageKeys and throw this message by ValidationMessageException.

OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}
Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}

    • -13
    • +24
    ./openlmis/referencedata/web/RequisitionGroupControllerIntegrationTest.java
  1. … 1 more file in changeset.
OLMIS-6470: Fixed updating Supervisory Node via PUT api/requisitionGroups/{id}

    • -13
    • +24
    ./openlmis/referencedata/web/RequisitionGroupControllerIntegrationTest.java
  1. … 1 more file in changeset.