Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-4871 Rename performance-data folder to demo-data
OLMIS-4871 Rename performance-data folder to demo-data
OLMIS-4871 Move demo data to TestDataInitializer

* Change demo data strategy from JSON to CSV.

* Add more data, not from Mockaroo, but from UAT2.

* Remove old demo-data files.

* Fix sonar bugs.

  1. … 80 more files in changeset.
Revert demo data back to JSON strategy

Also, change requisition group FP 1 to use regular Monthly processing schedule (to pass requisition contract tests).

  1. … 71 more files in changeset.
OLMIS-4871 Move demo data to TestDataInitializer

* Change demo data strategy from JSON to CSV.

* Add more data, not from Mockaroo, but from UAT2.

* Remove old demo-data files.

* Fix sonar bugs.

  1. … 71 more files in changeset.
Revert "OLMIS-4871 Move demo data to TestDataInitializer"

This reverts commit 55caa5a79edd5c686a07cd33ad8b8f93fc350b61.

  1. … 69 more files in changeset.
OLMIS-4871 Move demo data to TestDataInitializer

* Change demo data strategy from JSON to CSV.

* Add more data, not from Mockaroo, but from UAT2.

* Remove old demo-data files.

  1. … 69 more files in changeset.
I think I just got lost for a moment with the demo data and what is being done at build time, what is done at runtime, where is demo data loaded (I believe it's completely separate from these class...

I think I just got lost for a moment with the demo data and what is being done at build time, what is done at runtime, where is demo data loaded (I believe it's completely separate from these classes). Anyway, looks good.

This has been moved up

This has been moved up

Thanks Pawel for the catch. You inspired me to make it more testable and so see: Resource2Db and it's unit test Resource2DbTest.

Thanks Pawel for the catch. You inspired me to make it more testable and so see:
Resource2Db and it's unit test Resource2DbTest.

A reason, though it's not a great one, is that I started with the SQL approach over the CSV. I kept this as SQL to show that if you need to do SQL, you can and it's supported in TestDataInitializer.

A reason, though it's not a great one, is that I started with the SQL approach over the CSV. I kept this as SQL to show that if you need to do SQL, you can and it's supported in TestDataInitializer.

They are used in Mockaroo. I considered leaving them in the tool, however for purposes of implementation extension, open source, good revision practice, and so on I felt these, along with the schem...

They are used in Mockaroo. I considered leaving them in the tool, however for purposes of implementation extension, open source, good revision practice, and so on I felt these, along with the schemas which I just realized aren't in this review, and should be, are good things to have here.

It means that only 4 geo zone's have been copied here, as opposed to the others adjacent to this file which have "all". It's semantically meant to hold the contents of this file to that expectation.

It means that only 4 geo zone's have been copied here, as opposed to the others adjacent to this file which have "all". It's semantically meant to hold the contents of this file to that expectation.

Paweł Gesek: which ones do you think it's missing? The change in ref-distro? The overall context is that it's mighty convenient to be able to load / not load demo data and performance data by activ...

Paweł Gesek: which ones do you think it's missing? The change in ref-distro? The overall context is that it's mighty convenient to be able to load / not load demo data and performance data by active profiles.

Looks good to me, although I am curious about the answers to Pawel's questions as well.

Looks good to me, although I am curious about the answers to Pawel's questions as well.

Overall this looks good. I am missing some for the context in the demo data loading changes I think, since don't think this are all the commits - but overall the approach seems fine.

Overall this looks good. I am missing some for the context in the demo data loading changes I think, since don't think this are all the commits - but overall the approach seems fine.

by the way, these files are unused currently right?

by the way, these files are unused currently right?

and others

and others

does the 4 at the end of the filename have any meaning?

does the 4 at the end of the filename have any meaning?

Any reason why users are stored in an sql file, not csv?

Any reason why users are stored in an sql file, not csv?

Move this static field higher up

Move this static field higher up

should probably close this stream

should probably close this stream

Note a few things: *performance data here isn't complete, it's not meant to be *more guidance documentation is forthcoming, this review is more for the mechanism - including how to generate the d...

Note a few things:

  • performance data here isn't complete, it's not meant to be
  • more guidance documentation is forthcoming, this review is more for the mechanism - including how to generate the data
  • how demo data is loaded has changed to be based on spring profile. This is a little cleaner and makes it easier to load demo-data at different times to test performance data.
OLMIS-2883, remove old demo-data loading
OLMIS-2883, remove old demo-data loading
OLMIS-2883, use spring profile for demo data loading

  1. … 4 more files in changeset.