CHANGELOG.md

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Ok, thanks

Ok, thanks

Probably functional tests will fail because of missing orderables like ARV0001, Male Condom, IPV - 5 dose,injection and some other. You can find them here: https://github.com/OpenLMIS/openlmis-func...

Probably functional tests will fail because of missing orderables like ARV0001, Male Condom, IPV - 5 dose,injection and some other. You can find them here: https://github.com/OpenLMIS/openlmis-functional-tests/search?l=Gherkin&q=product. I'm not sure what should we do - adjust tests or restore those orderables.

I have not changed products that have a connection to commodity types or trade items. I have tried to not change products we use for testing but I will ask our QA's to check this.

I have not changed products that have a connection to commodity types or trade items. I have tried to not change products we use for testing but I will ask our QA's to check this.

OLMIS-6363 Update product names and codes for demo data to be more meaningful.
OLMIS-6363 Update product names and codes for demo data to be more meaningful.
OLMIS-6363 Update product names and codes for demo data to be more meaningful.

  1. … 1 more file in changeset.
removed

removed

Yes. The table can contain a lot of data so adding columns and set default values could drop performance

Yes. The table can contain a lot of data so adding columns and set default values could drop performance

Is it because dropping and recreating is faster?

Is it because dropping and recreating is faster?

I wanted to separate loading csv files from services (as from demo-data directory in each service) from those which are in the demo-data repository. Just for the sake of clarity.

I wanted to separate loading csv files from services (as from demo-data directory in each service) from those which are in the demo-data repository. Just for the sake of clarity.

I don't think we should be settings this in the constructor. I might want to use this constructor in retrieval endpoints, for example Isn't doing this in PrePersist/Update annotated method enough?

I don't think we should be settings this in the constructor. I might want to use this constructor in retrieval endpoints, for example

Isn't doing this in PrePersist/Update annotated method enough?

OLMIS-6358: Added versioning to Facility Type Approved Product resource
OLMIS-6358: Added versioning to Facility Type Approved Product resource
Why do we need to keep it in a separate file? (as opposed to eg. load_data.sql)

Why do we need to keep it in a separate file? (as opposed to eg. load_data.sql)

In the following review, I only added a new field to the FTAP resource. I will adjust endpoints in next commits and reviews. Stay tuned.

In the following review, I only added a new field to the FTAP resource. I will adjust endpoints in next commits and reviews. Stay tuned.

OLMIS-6358: Added versioning to Facility Type Approved Product resource

  1. … 21 more files in changeset.
I didn't find any place where we are comparing dates from the database to the current timestamp, but I replaced hardcoded zone with SQL function NOW().

I didn't find any place where we are comparing dates from the database to the current timestamp, but I replaced hardcoded zone with SQL function NOW().

OLMIS-6374 Performance test server does not load all demo data
OLMIS-6374 Performance test server does not load all demo data
could check how do we handle such cases in other parts of the system?

could check how do we handle such cases in other parts of the system?

OLMIS-6374 Add new profile for audit logging.

  1. … 1 more file in changeset.
OLMIS-6390: Added changelog