openlmis-referencedata

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6675: Added entity graph for Orderable with javax.persistence.loadgraph hint

OLMIS-6566: Renamed methods to better describe what they do

Changelog reminder.

Changelog reminder.

OLMIS-6658 Removed joins checking if programOrderable for Ftap's program is active in order to improve...
OLMIS-6658 Removed joins checking if programOrderable for Ftap's program is active in order to improve...
OLMIS-6658 Removed joins checking if programOrderable for Ftap's program is active in order to improve performance of FTAP search query

    • -2
    • +12
    /src/main/resources/api-definition.yaml
What about changelog? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

What about changelog?

OLMIS-6566: Updated orderable search query
OLMIS-6566: Updated orderable search query
OLMIS-6566: Added constant for fullProductName string

Yes. I changed it to make sure it returns GMT. Note: when testing the api with Postman Last-Modified header was set with GMT.

Yes. I changed it to make sure it returns GMT. Note: when testing the api with Postman Last-Modified header was set with GMT.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

I made sure that it returns GMT now.

So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

Working on it. JPQL does not support LIMIT I think so I am looking into Pageable. EDIT: So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

Working on it. JPQL does not support LIMIT I think so I am looking into Pageable.
EDIT: So it looks like it may not make a lot of difference (if not make results worse) to use JPQL.

OLMIS-6566: Refactored searching for orderables to use JPQL instead of native queries Also removed entity graph because it did not help with n+1 problem

OLMIS-6611: Refactored to use GMT and removed one profiler

That is not correct. Last-Modified and If-Modified-Since headers should always use GMT: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/d...
This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT: "HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/...

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT:
"HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT: "HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/...

This is the date that we use in Last-Modified and If-Modified-Since, right? If so, it should use GMT:
"HTTP dates are always expressed in GMT, never in local time." - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Last-Modified https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since

Yes. Of course. Changed it to use count-query.

Yes. Of course. Changed it to use count-query.

I tried, however as there are different objects (MultiValueMap, OrderableSearchParams, QueryOrderableSearchParams, SearchParams) passed as arguments in different methods I wanted to somehow unify i...

I tried, however as there are different objects (MultiValueMap, OrderableSearchParams, QueryOrderableSearchParams, SearchParams) passed as arguments in different methods I wanted to somehow unify it for future data flow. If it could be done in a more simple way I would need a hint.

Changed it to get system default. Also in tests.

Changed it to get system default. Also in tests.

Ops. Removed.

Ops. Removed.

Changed it.

Changed it.

Changed it.

Changed it.

Yes. Changed it.

Yes. Changed it.

OLMIS-6611: Refactored a method to use count query instead of a try-catch

OLMIS-6566: Added entity graph for Orderable