Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5153: moved installing gettext from run script to build
OLMIS-5153: moved installing gettext from run script to build
OLMIS-5153: moved installing gettext from run script to build

  1. … 1 more file in changeset.
Add missing module name.

Add missing module name.

Allows getting?

Allows getting?

remove this

remove this

So...... this line is replacing placeholders in openlmis.js with env variables and saving result to some temp file. The problem is that if envsubst encounters any ${SOMETHING} and there is no SOMET...

So...... this line is replacing placeholders in openlmis.js with env variables and saving result to some temp file. The problem is that if envsubst encounters any ${SOMETHING} and there is no SOMETHING variable exported empty string will be placed there, unfortunately there is one place in some library that uses "${". The only way to avoid this is to pass every env variable name that we want to replace to envsubst so I'm passing those using "`printf ${%s}.......

Yes you are right so we can stay with current approach https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

Yes you are right so we can stay with current approach

Then we would have a lot of code duplication

Then we would have a lot of code duplication

A lot of ng-if here. Maybe it would be better to have two files and select correct based on flag? Not sure if this is a easy task in angular/js

A lot of ng-if here. Maybe it would be better to have two files and select correct based on flag? Not sure if this is a easy task in angular/js

http://mrwgifs.com/wp-content/uploads/2013/10/The-Big-Lebowski-WTF-Expression-While-Checking-Things-Out.gif
OLMIS-4797: added feature flag for batch approve screen
OLMIS-4797: added feature flag for batch approve screen
OLMIS-4797: fixed replacing only existing env variables

OLMIS-4797: changed envreplace to envsubst

OLMIS-4797: added temporary logging for replacing feature flags

OLMIS-4797: added printing feature flag value

OLMIS-4797: added info if openlmis.js was found

OLMIS-4797: fixed path to main js file

OLMIS-4797: added envreplace in run.sh for enabling on deployment feature flag toggling

OLMIS-1920: Created new publishing repository

  1. … 18 more files in changeset.