Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-4963: Fix missing autosize-input dependency

OLMIS-4963: Fix missing autosize-input dependency

OLMIS-4963: Fix missing autosize-input dependency

OLMIS-4963: Fix missing autosize-input dependency

OLMIS-4963: Fix missing autosize-input dependency

OLMIS-4963: Fix missing autosize-input dependency

It's created by yarn

It's created by yarn

Where is the bower_components dir coming from now?

Where is the bower_components dir coming from now?

OLMIS-3415: Remove bower.json

I agree that we should ultimately use webpack instead of bundling dependencies ourselves. I'll try using yarn for now. Unlike npm, it seems to be capable of getting single js files (analytics.js)

I agree that we should ultimately use webpack instead of bundling dependencies ourselves. I'll try using yarn for now. Unlike npm, it seems to be capable of getting single js files (analytics.js)

I'll give it a try. It seems that we will be able to get analytics.js with yarn

I'll give it a try. It seems that we will be able to get analytics.js with yarn

What about giving yarn a try? Bower even have a guide on how to do it - https://bower.io/blog/2017/how-to-migrate-away-from-bower/

What about giving yarn a try? Bower even have a guide on how to do it - https://bower.io/blog/2017/how-to-migrate-away-from-bower/

And, to be honest, it's something I would love to tackle personally.

And, to be honest, it's something I would love to tackle personally.

Other approach we could take is switching to webpack completely, but it might be really painful... We could cheese it a bit and postpone adding require everywhere but using require.context, but it ...

Other approach we could take is switching to webpack completely, but it might be really painful... We could cheese it a bit and postpone adding require everywhere but using require.context, but it would still be a significant amount of work to do, but most likely only here.

I guess that's the whole point of this ticket, isn't it?

I guess that's the whole point of this ticket, isn't it?

Should I continue migrating all the other components? If we did that, we could completely remove bower

Should I continue migrating all the other components? If we did that, we could completely remove bower

This task joins package jsons from all the services and installs their dependencies. With the initial "npm install" we only install development dependencies. Do you have an idea on how should we ap...

This task joins package jsons from all the services and installs their dependencies. With the initial "npm install" we only install development dependencies. Do you have an idea on how should we approach this?

This task feels redundant to be honest. We need npm in order to install grunt.

This task feels redundant to be honest. We need npm in order to install grunt.

Perhaps we should give yarn a try as migrating solely to npm seems problematic.

Perhaps we should give yarn a try as migrating solely to npm seems problematic.

We should get rid of the bower completely

We should get rid of the bower completely

Here's a proposed solution: I modified our existing tasks in dev-ui to support npm dependencies. It's not a perfect one - we are still using wiredep which is designed for bower. An alternative is t...

Here's a proposed solution: I modified our existing tasks in dev-ui to support npm dependencies. It's not a perfect one - we are still using wiredep which is designed for bower. An alternative is to use webpack or browserify to bundle our files, which would require a lot more work and possibly refactoring the code. After migrating all the dependencies, we could completely remove bower. Please let me know what do you think about it and if I should continue migrating all the services.

We will need a second package.json file in order to migrate dependencies in dev-ui. If we were to put them in devDependencies it wouldn't work in dependent components

We will need a second package.json file in order to migrate dependencies in dev-ui. If we were to put them in devDependencies it wouldn't work in dependent components

This override is used by wiredep to pick the correct js. It used index.js by default

This override is used by wiredep to pick the correct js. It used index.js by default

I didn't figure out how to migrate analytics.js yet. Perhaps we could use some wrapper npm module and refactor our code.

I didn't figure out how to migrate analytics.js yet. Perhaps we could use some wrapper npm module and refactor our code.

After migrating all the dependencies, we could completely remove bower

After migrating all the dependencies, we could completely remove bower

OLMIS-3415: Support NPM dependencies
OLMIS-3415: Support NPM dependencies
OLMIS-1920: Changed build process to use /openlmis-requisition-ui

  1. … 3 more files in changeset.