Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge pull request #2 from OpenLMIS/hapi-fhir-upgrade

HAPI FHIR upgrade from 3.4.0 to 3.7.0

  1. … 1 more file in changeset.
Fix typo

Update api definitions with measure and measurereport

OLMIS-6066: Resolved issues with subscriptions

  1. … 5 more files in changeset.
OLMIS-6066: Upgrade gradle to 5.2.1 and spring boot to 2.1.1

  1. … 10 more files in changeset.
OLMIS-6066: Added database migrations

    • -0
    • +84
    ./db/migration/20190320094412184__upgrade_to_3_5_0.sql
    • -0
    • +20
    ./db/migration/20190320110942964__upgrade_to_3_6_0.sql
Sure, done.

Sure, done.

We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that ...

We should verify with the requisition service, but it doesn't mean we shouldn't add to all of them. Thanks for doing so - I'd suggest adding the same to the template service, as it's expected that all services have this switched on.

OLMIS-4531: Added compressing to HTTP POST responses

  1. … 1 more file in changeset.
1. The ticket states that compression should be tested on initiating a requisition, that's why it is currently added only to the requisition service. 2. I think about disabling compression in nginx...

1. The ticket states that compression should be tested on initiating a requisition, that's why it is currently added only to the requisition service.
2. I think about disabling compression in nginx configuration.

Two questions: *Why was it only added to the requisition service? *It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way...

Two questions:

  • Why was it only added to the requisition service?
  • It seems that for GET requests we will now be doing double compression (on the application server and on reverse proxy); any way to avoid that?
OLMIS-4531: Added compressing to HTTP POST responses
OLMIS-4531: Added compressing to HTTP POST responses
I created the review to make sure Lukas and you are aware of the auto-commit configuration changes. I will close this review.

I created the review to make sure Lukas and you are aware of the auto-commit configuration changes. I will close this review.

removed misleading method

removed misleading method

added

added

removed

removed

The name might be a little misleading. Wouldn't it make more sense to name it something telling us we're doing a request here?

The name might be a little misleading. Wouldn't it make more sense to name it something telling us we're doing a request here?

I think that this hides an important problem (201 being returned before the object is created). This information should definitely be propagated up and investigated.

I think that this hides an important problem (201 being returned before the object is created). This information should definitely be propagated up and investigated.

no, because we don't set id in the URL (the first parameter) and we use POST which basically is used to create objects. I created this private method to avoid code duplication.

no, because we don't set id in the URL (the first parameter) and we use POST which basically is used to create objects. I created this private method to avoid code duplication.

To make sure that a location on the FHIR server will be created. On CI there were situations where one request returns 201 status code but next one - which retrieve the object - returns 404 status ...

To make sure that a location on the FHIR server will be created. On CI there were situations where one request returns 201 status code but next one - which retrieve the object - returns 404 status code. I didn't have this locally so I thought that maybe we do something too fast in tests

This could use a Javadoc as the other newly-added exception have.

This could use a Javadoc as the other newly-added exception have.

Does this mean we will be able to update with this method aswell?

Does this mean we will be able to update with this method aswell?

I don't quite understand what needs to be reviewed here?

I don't quite understand what needs to be reviewed here?

Nevermind, I can see now.

Nevermind, I can see now.