Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Elias I still see template in some places like: ResourceServerSecurityConfiguration, VersionController

Elias I still see template in some places like: ResourceServerSecurityConfiguration, VersionController

from sonar: Immediately return this expression instead of assigning it to the temporary variable "extraProperties".

from sonar: Immediately return this expression instead of assigning it to the temporary variable "extraProperties".

could you give this explanation in the file as a comment?

could you give this explanation in the file as a comment?

maybe it would be good to leave a comment why we use the given version

maybe it would be good to leave a comment why we use the given version

Do we need to fix something in the auth service? I know it looks for available services and updates data so all services are visible by the auth service

Do we need to fix something in the auth service? I know it looks for available services and updates data so all services are visible by the auth service

you are right. but for an odd reason, we need the hibernate libraries. tried to remove those and the service does not start.

you are right. but for an odd reason, we need the hibernate libraries. tried to remove those and the service does not start.

currently, we do not have any usecase for these. If they are needed, I will just add them in the configuration file.

currently, we do not have any usecase for these. If they are needed, I will just add them in the configuration file.

Yes. I will change this once I have the necessary entry fixed in the auth service.

Yes. I will change this once I have the necessary entry fixed in the auth service.

This is trying to use the same version of spring boot as hapi-fhir is using. https://github.com/jamesagnew/hapi-fhir/blob/master/pom.xml#L531-L534 Interestingly, one of the version numbers is upd...

This is trying to use the same version of spring boot as hapi-fhir is using.

https://github.com/jamesagnew/hapi-fhir/blob/master/pom.xml#L531-L534

Interestingly, one of the version numbers is updated since I cloned the repository but that should not cause worry.

Spring boot 1.5.6 loads spring version 4.x. FHIR Server depends on Spring Version 5.0.6. This piece of code makes sure that Spring v5 is loaded instead of the default v4.

Spring boot 1.5.6 loads spring version 4.x. FHIR Server depends on Spring Version 5.0.6. This piece of code makes sure that Spring v5 is loaded instead of the default v4.

please, update the following properties

please, update the following properties

do we need those two entries? I thought they are transitive dependencies for spring library

do we need those two entries? I thought they are transitive dependencies for spring library

could we use the same format for all dependencies?

could we use the same format for all dependencies?

Not quite sure about this part. Could you explain why you added it?

Not quite sure about this part. Could you explain why you added it?

why not the latest version? 1.5.16

why not the latest version? 1.5.16

we probably should add locale settings and use them in code? currencyCode=${CURRENCY_CODE:USD} currencySymbol=${CURRENCY_SYMBOL:$} currencySymbolSide=${CURRENCY_SYMBOL_SIDE:left} currencyDecimalPla...

we probably should add locale settings and use them in code?

currencyCode=${CURRENCY_CODE:USD}
currencySymbol=${CURRENCY_SYMBOL:$}
currencySymbolSide=${CURRENCY_SYMBOL_SIDE:left}
currencyDecimalPlaces=${CURRENCY_DECIMAL_PLACES:2}

groupingSeparator=${GROUPING_SEPARATOR:,}
groupingSize=${GROUPING_SIZE:3}
decimalSeparator=${DECIMAL_SEPARATOR:.}

dateFormat=${DATE_FORMAT:dd/MM/yyyy}
dateTimeFormat=${DATE_TIME_FORMAT:dd/MM/yyyy HH:mm:ss}
why referencedata? I thought that each service should have unique id

why referencedata? I thought that each service should have unique id

why update? My understanding is that the hibernate will be able to modify the database schema. We should only change schema by migrations.

why update? My understanding is that the hibernate will be able to modify the database schema. We should only change schema by migrations.

change template to correct one

change template to correct one

Could we modify the method so it will not create a local variable and anonymous class would be presented as a lambda? I think this is the one of sonar code smell

Could we modify the method so it will not create a local variable and anonymous class would be presented as a lambda? I think this is the one of sonar code smell

can't we take those settings from application.properties file?

can't we take those settings from application.properties file?

Configure HAPI FHIR servlet and consul configs
Configure HAPI FHIR servlet and consul configs
Configured HAPI FHIR servlet and consul configs

    • -60
    • +0
    ./CustomWebMvcConfigurerAdapter.java
  1. … 10 more files in changeset.
changed package from template to hapifhir

    • -64
    • +0
    ./errorhandling/AbstractErrorHandling.java
    • -39
    • +0
    ./errorhandling/GlobalErrorHandling.java
    • -52
    • +0
    ./exception/BaseMessageException.java
    • -52
    • +0
    ./i18n/ExposedMessageSourceImpl.java
    • -32
    • +0
    ./security/MethodSecurityConfiguration.java
    • -138
    • +0
    ./security/ResourceServerSecurityConfiguration.java
  1. … 17 more files in changeset.
remove unused template files

    • -33
    • +0
    ./util/ConditionalUuidGenerator.java
  1. … 3 more files in changeset.
OLMIS-4295: updated checkstyle to new google style

fixed LICENCE header

fixed import order

fixed minor code style issues

    • -3
    • +3
    ./errorhandling/AbstractErrorHandling.java
    • -3
    • +3
    ./errorhandling/GlobalErrorHandling.java
  1. … 16 more files in changeset.
OLMIS-2534: Set page size to 2000 in AuditLogInitializer