README.md

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
We're getting rid of the null check, which is the whole point of Optional, isn't it?

We're getting rid of the null check, which is the whole point of Optional, isn't it?

for me, this is exactly the same.

for me, this is exactly the same.

Optional.ofNullable(findFacility(location.getIdElement().getIdPart()) .orElse(() ->{ facility = new FacilityDto(); facility.setId(UUID.fromString(location.getIdElement().getIdPart()); created = tru...

Optional.ofNullable(findFacility(location.getIdElement().getIdPart())
.orElse(() ->

Unknown macro: { facility = new FacilityDto(); facility.setId(UUID.fromString(location.getIdElement().getIdPart()); created = true; return facility; }

).

Wouldn't something like this work?

We're just making this non-private just for the sake of tests, which is not a good approach. Anyway, this is rather minor...

We're just making this non-private just for the sake of tests, which is not a good approach. Anyway, this is rather minor...

We do that in other places

We do that in other places

So I would rather hide this instead.

So I would rather hide this instead.

this property is used in tests

this property is used in tests

I don't think so.

I don't think so.

Is this intended to be package-private?

Is this intended to be package-private?

Yeah, but could make use of orElse here somehow?

Yeah, but could make use of orElse here somehow?

in both cases, I need a facility resource. The difference is only if I should create a facility with the given ID or should I update it.

in both cases, I need a facility resource. The difference is only if I should create a facility with the given ID or should I update it.

Could we make an Optional out of this?

Could we make an Optional out of this?

OLMIS-5415: Syncing data with OpenLMIS reference data
OLMIS-5415: Syncing data with OpenLMIS reference data
Thank's that all resources in the FHIR server will have UUID in the id field and we will be able to create an OpenLMIS's resource with exactly the same value in the id field.

Thank's that all resources in the FHIR server will have UUID in the id field and we will be able to create an OpenLMIS's resource with exactly the same value in the id field.

OLMIS-5415: Syncing data with OpenLMIS reference data

  1. … 26 more files in changeset.
OLMIS-5382: Updated resourceId, updated service name, replaced template with service name and updated documentations.

  1. … 5 more files in changeset.
Elias I still see template in some places like: ResourceServerSecurityConfiguration, VersionController

Elias I still see template in some places like: ResourceServerSecurityConfiguration, VersionController

from sonar: Immediately return this expression instead of assigning it to the temporary variable "extraProperties".

from sonar: Immediately return this expression instead of assigning it to the temporary variable "extraProperties".

could you give this explanation in the file as a comment?

could you give this explanation in the file as a comment?

maybe it would be good to leave a comment why we use the given version

maybe it would be good to leave a comment why we use the given version

Do we need to fix something in the auth service? I know it looks for available services and updates data so all services are visible by the auth service

Do we need to fix something in the auth service? I know it looks for available services and updates data so all services are visible by the auth service

you are right. but for an odd reason, we need the hibernate libraries. tried to remove those and the service does not start.

you are right. but for an odd reason, we need the hibernate libraries. tried to remove those and the service does not start.

currently, we do not have any usecase for these. If they are needed, I will just add them in the configuration file.

currently, we do not have any usecase for these. If they are needed, I will just add them in the configuration file.

Yes. I will change this once I have the necessary entry fixed in the auth service.

Yes. I will change this once I have the necessary entry fixed in the auth service.

This is trying to use the same version of spring boot as hapi-fhir is using. https://github.com/jamesagnew/hapi-fhir/blob/master/pom.xml#L531-L534 Interestingly, one of the version numbers is upd...

This is trying to use the same version of spring boot as hapi-fhir is using.

https://github.com/jamesagnew/hapi-fhir/blob/master/pom.xml#L531-L534

Interestingly, one of the version numbers is updated since I cloned the repository but that should not cause worry.