Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I needed to restore mem limit because it does not help https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/sad.gif

I needed to restore mem limit because it does not help

merge with other calculate fields to: Calculated fields should be calculated properly and not change after status changes

merge with other calculate fields to: Calculated fields should be calculated properly and not change after status changes

merge with other calculate fields to: Calculated fields should be calculated properly and not change after status changes

merge with other calculate fields to: Calculated fields should be calculated properly and not change after status changes

merge with other calculate fields to: Calculated fields should be calculated properly and not change after status changes

merge with other calculate fields to: Calculated fields should be calculated properly and not change after status changes

merge with: Warehouse Manager user should be able to convert requisition to order

merge with: Warehouse Manager user should be able to convert requisition to order

merge with: Warehouse Manager user should be able to convert requisition to order

merge with: Warehouse Manager user should be able to convert requisition to order

merge with: Warehouse Manager user should be able to convert requisition to order

merge with: Warehouse Manager user should be able to convert requisition to order

merge with: Warehouse Manager user should be able to convert requisition to order

merge with: Warehouse Manager user should be able to convert requisition to order

OLMIS-4930: Merge similar tests, divided into two files by emergency flag
OLMIS-4930: Merge similar tests, divided into two files by emergency flag
OLMIS-4930: Merge similar tests and divided into two files by emergency flag

  1. … 4 more files in changeset.
OLMIS-2005: Added test for 2-way approval process
OLMIS-2005: Added test for 2-way approval process
OLMIS-2005: Added test for 2-way approval process

  1. … 1 more file in changeset.
Thanks, I have fixed the case of the label. Since that is a trivial change, I am going to close this review.

Thanks, I have fixed the case of the label. Since that is a trivial change, I am going to close this review.

Looks good to me. I made one small comment.

Looks good to me. I made one small comment.

Maybe want to name it "Previous requisition" to match case of others.

Maybe want to name it "Previous requisition" to match case of others.

Seems like there is no ticket called OLMIS-4861?

Seems like there is no ticket called OLMIS-4861?

Hi Elias. I added quick fix for contract test to pass because it failed because of your changes. If you think this should be done in other way feel free to provide changes.

Hi Elias. I added quick fix for contract test to pass because it failed because of your changes. If you think this should be done in other way feel free to provide changes.

OLMIS-4681: Fixed broken contract test

OLMIS-4681 - Add source and additional options for 'skipped' column
OLMIS-4681 - Add source and additional options for 'skipped' column