Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Could we change it something like: "Fixed issue with endpoint '/api/requisitions/search' with 'modifiedDateFrom' parameter not returning all data: *Updated requisition to set the value of created ...

Could we change it something like:

"Fixed issue with endpoint '/api/requisitions/search' with 'modifiedDateFrom' parameter not returning all data:
*Updated requisition to set the value of created date as the modified date when initiating."

Looks good, but the CHANGELOG is missing. This changes the logic of populating the modified date so it should be explained there

Looks good, but the CHANGELOG is missing. This changes the logic of populating the modified date so it should be explained there

OLMIS-6812: Set Requisition modified date before persisting it in the db
OLMIS-6812: Set Requisition modified date before persisting it in the db
OLMIS-6812: update modified in requisition before update date if needed

    • -3
    • +17
    ./requisition/RequisitionStepDefs.java
OLMIS-6812: update modified date if needed

    • -3
    • +17
    ./requisition/RequisitionStepDefs.java
OLMIS-6392 Fixed contract tests for fulfillment POD after adding orderable versioning

    • -1
    • +9
    ./fulfillment/FulfillmentStepDefs.java
  1. … 1 more file in changeset.
Done.

Done.

please revert that. IN HAPI FHIR there is still versionId field

please revert that. IN HAPI FHIR there is still versionId field

Revert "OLMIS-6402: Renamed versionId to versionNumber"

This reverts commit b31873559ed232c086176f952ee94eee6f30b87b.

    • -2
    • +2
    ./hapifhir/OlmisResourceTestHelper.java
OLMIS-6402: Renamed versionId to versionNumber part I
OLMIS-6402: Renamed versionId to versionNumber part I
OLMIS-6402: Renamed versionId to versionNumber

    • -2
    • +2
    ./hapifhir/OlmisResourceTestHelper.java
OPENLMIS-5177 Change test case to force failure.

OLMIS-5560: Added contract test for beginning balance and stock on hand calculations
OLMIS-5560: Added contract test for beginning balance and stock on hand calculations
OLMIS-5560: Added contract test for beginning balance and stock on hand calculations

    • -5
    • +34
    ./requisition/RequisitionStepDefs.java
  1. … 1 more file in changeset.
OLMIS-5906: Added tests for multiple suppliers
OLMIS-5906: Added tests for multiple suppliers
OLMIS-5906: Added tests for multiple suppliers

    • -0
    • +82
    ./requisition/RequisitionStepDefs.java
  1. … 3 more files in changeset.
Retrieve the requisitionGroup from the database, before you assert anything. This test will pass even if you delete the line that saves to the database, which makes no sense.

Retrieve the requisitionGroup from the database, before you assert anything. This test will pass even if you delete the line that saves to the database, which makes no sense.

On the other hand, even though you got 200 response, nothing was modified. I'd say it's not breaking.

On the other hand, even though you got 200 response, nothing was modified. I'd say it's not breaking.