docker-compose.yml

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I tried to add this header to traits but tests failed as if they didn't see it this way.

I tried to add this header to traits but tests failed as if they didn't see it this way.

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

Can we use traits so that the header definitions don't need to be repeated for each of the endpoits? (This might not be possible with the RAML version we use, but it's worth checking)

Flyway is already mentioned in the first bullet point

Flyway is already mentioned in the first bullet point

have

have

Where do we use that? And can't we simply use max int constant from the Integer class?

Where do we use that? And can't we simply use max int constant from the Integer class?

OLMIS-6659 Updated Spring Boot version to 2.x
OLMIS-6659 Updated Spring Boot version to 2.x
looks good now

looks good now

We lack messages for these in messages_en.properties file (also, the mentioned file contains some obsolete translations we need to remove).

We lack messages for these in messages_en.properties file (also, the mentioned file contains some obsolete translations we need to remove).

I agree. We get rid of it in requisition but I can still se it in e.g. referencedata service

I agree. We get rid of it in requisition but I can still se it in e.g. referencedata service

Yep, it is only for demonstration purposes and should not be present in this service.

Yep, it is only for demonstration purposes and should not be present in this service.

Paweł Nawrocki So you think that I should remove it?

Paweł Nawrocki So you think that I should remove it?

I think that docker-compose.erd-generation is missing (if it's in the scope?)

I think that docker-compose.erd-generation is missing (if it's in the scope?)

We no longer use this file in our services.

We no longer use this file in our services.

This shouldn't be here. Please check the whole file for such things.

This shouldn't be here. Please check the whole file for such things.

I think this file should be changed to match other services.

I think this file should be changed to match other services.

I think this should be removed.

I think this should be removed.

Isn't this example controller from template-service?

Isn't this example controller from template-service?

Isn't this example repository from template-service?

Isn't this example repository from template-service?

The review name is invalid I guess

The review name is invalid I guess

What is it for?

What is it for?

OLMIS-2752: updated postgres + openlmis/dev versions
OLMIS-2752: updated postgres + openlmis/dev versions