openlmis-cce-ui

yarn.lock

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 28 Mar 19
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Apr 2019
4:20 pm

Chongsun Ahn

8:46 am

Nikodem Graczewski

Tuesday 02 Apr 2019
3:38 pm

Chongsun Ahn

Done.

Done.

3:37 pm

Łukasz Lewczyński

8:53 am

Chongsun Ahn

What about chained function calls, like moment.tz().format()?

What about chained function calls, like moment.tz().format()?

8:35 am

Nikodem Graczewski

Something like this: https://github.com/OpenLMIS/openlmis-ui-components/blob/master/src/openlmis-function-decorator/openlmis-function-decorator.spec.js

Something like this:
https://github.com/OpenLMIS/openlmis-ui-components/blob/master/src/openlmis-function-decorator/openlmis-function-decorator.spec.js

8:27 am

Chongsun Ahn

Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

8:11 am

Nikodem Graczewski

Great, thanks!

Great, thanks!

8:11 am

Nikodem Graczewski

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

8:09 am

Nikodem Graczewski

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

Monday 01 Apr 2019
8:28 pm

Chongsun Ahn

https://openlmis.atlassian.net/browse/OLMIS-6170

https://openlmis.atlassian.net/browse/OLMIS-6170

6:40 pm

Chongsun Ahn

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

Friday 29 Mar 2019
10:17 pm

Chongsun Ahn

Also changed the currency filter in ui-components to use the new localeService.

Also changed the currency filter in ui-components to use the new localeService.

10:17 pm

Chongsun Ahn

Done.

Done.

10:16 pm

Chongsun Ahn

Reduced the duplication.

Reduced the duplication.

10:16 pm

Chongsun Ahn

Done. Hopefully this is correct. Otherwise, I'm not sure how to go about implementing this.

Done. Hopefully this is correct. Otherwise, I'm not sure how to go about implementing this.

6:56 pm

Chongsun Ahn

Then how do we catch in the locale cache code to call getLocaleSettingsFromConfig? Is there a good code example that shows this? I basically copied this from currency service.

Then how do we catch in the locale cache code to call getLocaleSettingsFromConfig? Is there a good code example that shows this? I basically copied this from currency service.

5:25 pm

Chongsun Ahn

The whole datepicker format is confusing to me as well. Does it need to be different from the date format? And where is the documentation about its meaning, vs. the date formats?

The whole datepicker format is confusing to me as well. Does it need to be different from the date format? And where is the documentation about its meaning, vs. the date formats?

4:53 pm

Chongsun Ahn

It may be a non-issue, as it looks like anything that would use datepicker would probably use business dates, which does not represent an instant in time, and so timezone would not be important. Ad...

It may be a non-issue, as it looks like anything that would use datepicker would probably use business dates, which does not represent an instant in time, and so timezone would not be important. Additionally, the datepicker directive does use the openlmis date filter.

4:35 pm

Nikodem Graczewski

I agree that it uses separate format, but what I'm concerned about is that the ticket might not pass the QA because of the second point of the acceptance criteria as the date picker will show diffe...

I agree that it uses separate format, but what I'm concerned about is that the ticket might not pass the QA because of the second point of the acceptance criteria as the date picker will show different date format (most likely one without timezone).

4:27 pm

Chongsun Ahn

Yes but the datepicker format is a separate setting, and not in the reference data. I suppose we could add it, but it wasn't done in the other tickets, so this ticket just followed what was done.

Yes but the datepicker format is a separate setting, and not in the reference data. I suppose we could add it, but it wasn't done in the other tickets, so this ticket just followed what was done.

4:12 pm

Nikodem Graczewski

I see. Isn't the purpose of this ticket to make all components use the locales from the reference data?

I see. Isn't the purpose of this ticket to make all components use the locales from the reference data?

4:12 pm

Chongsun Ahn

Alright, I'll try to do the extra checking in the localeService.

Alright, I'll try to do the extra checking in the localeService.

4:09 pm

Chongsun Ahn

Basically the changes here are just to get the filters to use settings from reference data, and then the defaults if those aren't found (and to support timezone in the filters). Since datepicker is...

Basically the changes here are just to get the filters to use settings from reference data, and then the defaults if those aren't found (and to support timezone in the filters). Since datepicker isn't a filter and it doesn't have a corresponding reference data setting, it doesn't seem to apply to the work here. It looks like datepicker format uses a different date format already, even before this ticket.

4:04 pm

Nikodem Graczewski

So it will use different date format then?

So it will use different date format then?

4:04 pm

Nikodem Graczewski

I just thought we could move it to the localeService so it is not duplicated in both date and datetime filter.

I just thought we could move it to the localeService so it is not duplicated in both date and datetime filter.

4:03 pm

Chongsun Ahn

Update it how? It will already use dateFormat and timeZoneId from the locale settings if they are set, and there is no locale setting for a datepicker format from reference data.

Update it how? It will already use dateFormat and timeZoneId from the locale settings if they are set, and there is no locale setting for a datepicker format from reference data.

4:00 pm

Chongsun Ahn

You don't think it's necessary to make an extra check here that locale settings are set with date format and timezone?

You don't think it's necessary to make an extra check here that locale settings are set with date format and timezone?

3:58 pm

Chongsun Ahn

Do you mean the localeService? Probably the reason why I put this code in is just in case these settings are not in local storage.

Do you mean the localeService? Probably the reason why I put this code in is just in case these settings are not in local storage.

3:55 pm

Nikodem Graczewski

Yeah, sorry for the typo.

Yeah, sorry for the typo.