openlmis-upload

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Why are those commented out?

Why are those commented out?

use `is-empty` to be more SMACSS-y??

use `is-empty` to be more SMACSS-y??

oh ha! no we are talking past eachother here http://getbootstrap.com/css/#helper-classes-screen-readers http://webaim.org/techniques/css/invisiblecontent/ @extend .sr-only;
Seems to work great!

Seems to work great!

Nick Reid I've just add required to this input and everything seems to work..... at least I guess so

Nick Reid I've just add required to this input and everything seems to work..... at least I guess so

Nick Reid the problem is that attribute is already set to "file". Is there a way to set this regardless?

Nick Reid the problem is that attribute is already set to "file". Is there a way to set this regardless?

These improvements look good

These improvements look good

how about just `.file-upload` or `.openlmis-file-upload` ??

how about just `.file-upload` or `.openlmis-file-upload` ??

I've seen someone styling label and hiding input so probably it is a normal behaviour

I've seen someone styling label and hiding input so probably it is a normal behaviour

Shit, didn't realize that it was empty....... so stupid.......

Shit, didn't realize that it was empty....... so stupid.......

I'm surprised that clicking on the label will open the file input... is this how HTML normally works?

I'm surprised that clicking on the label will open the file input... is this how HTML normally works?

thanks for doing this!

thanks for doing this!

So, it seems like as of right now... if I tried to make a file input required by following our normal pattern, this wouldn't actually work... I'd like to be able to write: `<input id="foo" type="f...

So, it seems like as of right now... if I tried to make a file input required by following our normal pattern, this wouldn't actually work...

I'd like to be able to write: `<input id="foo" type="file" ng-model="example" required />`

I think a good way to accomplish this (with out rewritting ng-model required and other controllers that don't work here.... would be to add a text input into the directive, which is actually linked to ng-model... and the rest of this controller actually wraps (using parsers/formatters and validators)

... see above comment for set validity....

... see above comment for set validity....

What is this supposed to do? This sets the error key '' to null I think you want to ngModelController.$setValidity('openlmisFileUpload.wrongFileExtention', true);

What is this supposed to do? This sets the error key '' to null

I think you want to

ngModelController.$setValidity('openlmisFileUpload.wrongFileExtention', true);
Wrap these selectors as child selectors so they don't show up in unintended places!

Wrap these selectors as child selectors so they don't show up in unintended places!

it will be more maintainable to set 'align-items: baseline' (or flex end) on the parent

it will be more maintainable to set 'align-items: baseline' (or flex end) on the parent

For screen readers, this should be hidden, not `display:none`

For screen readers, this should be hidden, not `display:none`

Do we really need a class here? couldn't this just be a child selector?

Do we really need a class here? couldn't this just be a child selector?

If there is a selected file, lets change the message to "change file" — also, this button can hide the actual text by using "icon only"

If there is a selected file, lets change the message to "change file" — also, this button can hide the actual text by using "icon only"

Mateusz Kwiatkowski Yeah
Don't you think that select button should be always visible and the clear button only if file is selected?

Don't you think that select button should be always visible and the clear button only if file is selected?

No, it's already fixed, it's just leftover from older commit.

No, it's already fixed, it's just leftover from older commit.

Nikodem Graczewski So just rename the module to 'admin-cce-upload'?

Nikodem Graczewski So just rename the module to 'admin-cce-upload'?

We should probably add some tests here... https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/sad.gif

We should probably add some tests here...

Me neither, but the thing is those types don't really work well with the directive. https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/sad.gif

Me neither, but the thing is those types don't really work well with the directive.

This will break requisition-ui strings again, won't it?

This will break requisition-ui strings again, won't it?