openlmis-cce-ui/src/cce-inventory-item-details

inventory-item-details.html

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 14 Nov 17
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Nov 2017
6:47 am

Klaudia Pałkowska

Tuesday 14 Nov 2017
7:38 pm

Mateusz Kwiatkowski and Nikodem Graczewski

2:46 pm

Klaudia Pałkowska

I've added checking the right.

I've added checking the right.

2:45 pm

Klaudia Pałkowska

Done.

Done.

2:44 pm

Klaudia Pałkowska

I've added the right name.

I've added the right name.

2:26 pm

Nikodem Graczewski

I know that, but if we pass undefined as both programId and facilityId it will still treated as checking only for the right name.

I know that, but if we pass undefined as both programId and facilityId it will still treated as checking only for the right name.

1:26 pm

Klaudia Pałkowska

I've added if - else, because for 'Add equipment' button we check whether the user has that right, no matter what program and facility are associated.

I've added if - else, because for 'Add equipment' button we check whether the user has that right, no matter what program and facility are associated.

1:23 pm

Nikodem Graczewski

This should be enough. You can remove the if - else.

This should be enough. You can remove the if - else.

1:21 pm

Nikodem Graczewski

What right?

What right?

1:00 pm

Klaudia Pałkowska

OLMIS-3333: Updated edit buttons to be hidden if user does not have CCE_INVENTORY_EDIT right for inventory item's program and facility

Options
    • -2
    • +2
    ./inventory-item-details.html
  2. … 7 more files in changeset.
Monday 13 Nov 2017
3:44 pm

Mateusz Kwiatkowski

Please fix bug with editing functional status when user does not have edit inventory item right

Please fix bug with editing functional status when user does not have edit inventory item right

3:42 pm

Mateusz Kwiatkowski

1:14 pm

Łukasz Lewczyński

It would be good to create ticket (if necessary) and link here

It would be good to create ticket (if necessary) and link here

10:53 am

Nikodem Graczewski

I'm marking this as resolved. Implementing it will require a new ticket anyway, so there is no point in holding this one.

I'm marking this as resolved. Implementing it will require a new ticket anyway, so there is no point in holding this one.

Friday 10 Nov 2017
11:54 am

Nikodem Graczewski

I know that this is how we do it everywhere, however this feels like a DRY violation. I would propose introducing a "restrictedTo" directive that would take a right name and, optionally, any of th...

I know that this is how we do it everywhere, however this feels like a DRY violation.

I would propose introducing a "restrictedTo" directive that would take a right name and, optionally, any of the following - program, warehouse and supervisory note. That directive would then ask the authorizationService if the user has the required permissions and show or hide the element accordingly. What do you think about it Nick Reid?

I'm marking this as unresolved until then.

8:47 am

Klaudia Pałkowska

OLMIS-3333: Fixed edit button to be hidden when user does not have right
OLMIS-3333: Fixed edit button to be hidden when user does not have right
8:36 am

Klaudia Pałkowska

OLMIS-3333: Fixed edit button to be hidden when user does not have right

Options
    • -1
    • +1
    ./inventory-item-details.html
  2. … 3 more files in changeset.
Wednesday 25 Oct 2017
9:32 am

Mateusz Kwiatkowski

Tuesday 24 Oct 2017
7:22 pm

Nikodem Graczewski and Nick Reid

7:22 pm

Nikodem Graczewski

Nick Reid Mateusz Kwiatkowski So what do we want to do? Do want to add the LocalDatabase or leave it as it is?

Nick Reid Mateusz Kwiatkowski So what do we want to do? Do want to add the LocalDatabase or leave it as it is?

9:31 am

Mateusz Kwiatkowski

OLMIS-3296: added getting facility by id while creating inventory item

Options
    • -1
    • +1
    ./inventory-item-details.html
  2. … 4 more files in changeset.
Monday 23 Oct 2017
10:04 pm

Mateusz Kwiatkowski

We will be keeping them in the memory regardless, because we need to parse those permission strings and facilities to get proper set of data. There will never be 1000 programs, just a couple, facil...

We will be keeping them in the memory regardless, because we need to parse those permission strings and facilities to get proper set of data.
There will never be 1000 programs, just a couple, facilities have only id and name (in Malawi there are 700).

3:47 pm

Nick Reid

Overall this looks great – I do think there is a concern about how these data caches are stored to memory // but I think the search structure has become simpler – and I think it will be hard to imp...

Overall this looks great – I do think there is a concern about how these data caches are stored to memory // but I think the search structure has become simpler – and I think it will be hard to improve more with out running a profiler against it when there is performance data involved.

3:44 pm

Nick Reid

This does worry me – regardless of how big the dataset really gets.... Questions: (A) How much of this data can we create and save at login? (so it can be quickly loaded) (B) Loading and throwing ...

This does worry me – regardless of how big the dataset really gets....

Questions:
(A) How much of this data can we create and save at login? (so it can be quickly loaded)
(B) Loading and throwing away permissions data is ok // and should be data collected immedately if done in a promise
(C) Does this service really need to be a service? Could it just be a factory that gets instantiated? Ideally that will remove any data created in this screen from memory once the $scope is destroyed

If we can make small-ish data structures, and save them in localStorage (which is a super fast read/write) that would be best...

Overall, I think the best thing to do here, is figure out how to test it against the old version.... and make follow up tickets (IMHO, we have made this a step better, and perfect is something that never really happens)

9:46 am

Nikodem Graczewski

With this and performance data we're basically keeping 10000 facilities and 1000 programs in the memory (+ the permission strings) is it really a good idea Nick Reid?

With this and performance data we're basically keeping 10000 facilities and 1000 programs in the memory (+ the permission strings) is it really a good idea Nick Reid?

Sunday 22 Oct 2017
11:51 pm

Mateusz Kwiatkowski

Yea, I wasn't sure what we want to return if module did not register rights to this service.... so I'm just using all, as it was before. I could change it to return empty list if you want.

Yea, I wasn't sure what we want to return if module did not register rights to this service.... so I'm just using all, as it was before. I could change it to return empty list if you want.

11:49 pm

Mateusz Kwiatkowski

Those variables contain all data retrieved from localStorage.... I mean when loadData method is called it loads it here, I'm not sure if it's OK to keep it in memory after starting the page...... I...

Those variables contain all data retrieved from localStorage.... I mean when loadData method is called it loads it here, I'm not sure if it's OK to keep it in memory after starting the page...... I could remake this to call localStorage directly, but the problem is that we will be calling localStorage (later db) on each program change.....

Friday 20 Oct 2017
2:54 pm

Nick Reid

So, I'm a little lost with this review – and am going to get back to it on Sunday I played with the functionality and it seems right – so I'd be happy if this went through QA (assuming nikodem's e...

So, I'm a little lost with this review – and am going to get back to it on Sunday

I played with the functionality and it seems right – so I'd be happy if this went through QA (assuming nikodem's edits get made)

7:42 am

Nikodem Graczewski

I guess we no longer need the init flag here.

I guess we no longer need the init flag here.

7:38 am

Nikodem Graczewski

This is just awesome.

This is just awesome.