cce-edit-inventory-item

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
We want to make sure that both boolean true and String 'true' pass this.

We want to make sure that both boolean true and String 'true' pass this.

OLMIS-4515: Fixed broken test

    • -1
    • +1
    ./cce-edit-inventory-item.routes.spec.js
  1. … 1 more file in changeset.
and why this is not a new String()?

and why this is not a new String()?

Why do we map boolean to String?

Why do we map boolean to String?

We're not adding JSDocs for them. They wouldn't really give us much.

We're not adding JSDocs for them. They wouldn't really give us much.

Should this constructor have doc?

Should this constructor have doc?

how about some doc?

how about some doc?

OLMIS-5415: Disabled edit of some fields for externally managed facilities
OLMIS-5415: Disabled edit of some fields for externally managed facilities
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

  1. … 14 more files in changeset.
Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

aaaand here https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

aaaand here

and here

and here

same here

same here

maybe, just maybe we could put those withModel/withType in a new line?

maybe, just maybe we could put those withModel/withType in a new line?

OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

    • -7
    • +8
    ./cce-edit-inventory-item.routes.spec.js
    • -16
    • +15
    ./edit-inventory-item.html.spec.js
  1. … 22 more files in changeset.
Please fix duplicated description.

Please fix duplicated description.

This could use some tests.

This could use some tests.

OLMIS-4535: Added an abstract state for inventory item details and status update modals
OLMIS-4535: Added an abstract state for inventory item details and status update modals