cce-catalog-item

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

  1. … 13 more files in changeset.
Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

aaaand here https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

aaaand here

and here

and here

same here

same here

maybe, just maybe we could put those withModel/withType in a new line?

maybe, just maybe we could put those withModel/withType in a new line?

OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

    • -8
    • +15
    ./catalog-item-type.factory.spec.js
  1. … 21 more files in changeset.
Enabled eslint

  1. … 33 more files in changeset.
Fixed tech debt

  1. … 6 more files in changeset.
OLMIS-3243: Updated tests in modules cce-add-inventory-item and cce-catalog-item
OLMIS-3243: Updated tests in modules cce-add-inventory-item and cce-catalog-item
OLMIS-3243: Updated references to referencedata builders and fixed some tests

    • -0
    • +103
    ./catalog-item-data-builder.spec.js
    • -16
    • +11
    ./catalog-item-type.factory.spec.js
  1. … 16 more files in changeset.
I really like this.

I really like this.

OLMIS-3243: Added builders for InventoryItem and CatalogItem

    • -0
    • +85
    ./catalog-item-builder.spec.js
  1. … 5 more files in changeset.
We should introduce a fluent builder for InventoryItem class.

We should introduce a fluent builder for InventoryItem class.

It will be done as a scope of OLMIS-3333.

It will be done as a scope of OLMIS-3333.

Done.

Done.

We should angular.merge or Object.assign on those two objects. One of them will have href property and the other won't.

We should angular.merge or Object.assign on those two objects. One of them will have href property and the other won't.

Klaudia Pałkowska We should also make the status non-editable without required right.

Klaudia Pałkowska We should also make the status non-editable without required right.

Done.

Done.