openlmis-cce-ui / src

cce-alert

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 14 Sep 2018
9:26 am

Nikodem Graczewski

9:02 am

Mateusz Kwiatkowski and Klaudia Pałkowska

Thursday 13 Sep 2018
12:00 pm

Łukasz Lewczyński

11:52 am

Nikodem Graczewski

OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
9:23 am

Nikodem Graczewski <ngraczewski@soldevelo.com>

OLMIS-5389: Fixed ESLint Jasmine tech debts

Options
    • -1
    • +2
    ./cce-alert-repository-impl.spec.js
  2. … 14 more files in changeset.
Tuesday 11 Sep 2018
3:20 pm

Nikodem Graczewski

3:16 pm

Klaudia Pałkowska and Łukasz Lewczyński

3:05 pm

Nikodem Graczewski

Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

2:32 pm

Łukasz Lewczyński

aaaand here https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

aaaand here

2:32 pm

Łukasz Lewczyński

and here

and here

2:31 pm

Łukasz Lewczyński

same here

same here

2:31 pm

Łukasz Lewczyński

maybe, just maybe we could put those withModel/withType in a new line?

maybe, just maybe we could put those withModel/withType in a new line?

2:25 pm

Nikodem Graczewski

OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
2:23 pm

Nikodem Graczewski <ngraczewski@soldevelo.com>

OLMIS-4388: Fixed ESlint tech debt in specs

Options
    • -0
    • +15
    ./cce-alert-data-builder.spec.js
    • -2
    • +4
    ./cce-alert-repository-impl.spec.js
    • -17
    • +18
    ./cce-alert-repository.spec.js
    • -51
    • +60
    ./cce-alert.factory.spec.js
  5. … 20 more files in changeset.
Tuesday 26 Jun 2018
2:17 pm

Nikodem Graczewski <ngraczewski@soldevelo.com>

Enabled eslint

Options
    • -106
    • +0
    ./cce-alert-data-builder.js
    • -0
    • +105
    ./cce-alert-data-builder.spec.js
    • -1
    • +1
    ./cce-alert-repository-impl.js
    • -8
    • +8
    ./cce-alert-repository.js
    • -1
    • +1
    ./cce-alert.factory.js
    • -1
    • +1
    ./cce-alert.js
  7. … 30 more files in changeset.
Tuesday 13 Mar 2018
5:06 pm

Chongsun Ahn

6:26 am

Josh Zamor

6:26 am

Josh Zamor

lgtm.

lgtm.

6:25 am

Josh Zamor

Too true.

Too true.

Monday 12 Mar 2018
7:14 am

Chongsun Ahn

I found a way to avoid changing "en-US" to "en_US".

I found a way to avoid changing "en-US" to "en_US".

7:01 am

Chongsun Ahn <cahn922@yahoo.com>

OLMIS-4105 Define CCE alert default locale in controller

Instead of replacing hyphen with underscore for locale, just define it in the controller. This avoids any incorrect manipulation of the model.

Options
    • -14
    • +0
    ./cce-alert.factory.js
    • -30
    • +0
    ./cce-alert.factory.spec.js
  3. … 4 more files in changeset.
Saturday 10 Mar 2018
6:57 am

Chongsun Ahn

I did ask the question in the Slack #ui channel, but got no response. I also scoured the Internetz for any answers. I didn't ask anyone specifically though.

I did ask the question in the Slack #ui channel, but got no response. I also scoured the Internetz for any answers. I didn't ask anyone specifically though.

Friday 09 Mar 2018
11:23 pm

Chongsun Ahn

I believe that is handled in the not matching FHIR regex test.

I believe that is handled in the not matching FHIR regex test.

11:20 pm

Josh Zamor

This looks good, left one comment. Could we send the UI review question to Team Parrot where they might know how it works in Angular?

This looks good, left one comment. Could we send the UI review question to Team Parrot where they might know how it works in Angular?

11:16 pm

Josh Zamor

What do we do if the length is longer than 64 characters?

What do we do if the length is longer than 64 characters?

Wednesday 07 Mar 2018
8:18 pm

Chongsun Ahn

8:14 pm

Nikodem Graczewski and Mateusz Kwiatkowski

6:58 pm

Chongsun Ahn

Ticket created: https://openlmis.atlassian.net/browse/OLMIS-4270

Ticket created: https://openlmis.atlassian.net/browse/OLMIS-4270

6:36 pm

Mateusz Kwiatkowski

I tried it and as you said increasing timeout didn't help, it shows generic alert right away, I would create a bug for it.

I tried it and as you said increasing timeout didn't help, it shows generic alert right away, I would create a bug for it.

6:03 pm

Mateusz Kwiatkowski

I can take a look, it seems that we are doing similar things in many other places, it is strange that it does not work here

I can take a look, it seems that we are doing similar things in many other places, it is strange that it does not work here