cce-alert

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts
OLMIS-5389: Fixed ESLint Jasmine tech debts

  1. … 14 more files in changeset.
Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

Our linter ruleset allows it, it only requires dividing into separate lines if the chain is longer than 2.

aaaand here https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/smile.gif

aaaand here

and here

and here

same here

same here

maybe, just maybe we could put those withModel/withType in a new line?

maybe, just maybe we could put those withModel/withType in a new line?

OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs
OLMIS-4388: Fixed ESlint tech debt in specs

  1. … 20 more files in changeset.
Enabled eslint

    • -0
    • +105
    ./cce-alert-data-builder.spec.js
  1. … 30 more files in changeset.
lgtm.

lgtm.

Too true.

Too true.

I found a way to avoid changing "en-US" to "en_US".

I found a way to avoid changing "en-US" to "en_US".

OLMIS-4105 Define CCE alert default locale in controller

Instead of replacing hyphen with underscore for locale, just define it in the controller. This avoids any incorrect manipulation of the model.

  1. … 4 more files in changeset.
I did ask the question in the Slack #ui channel, but got no response. I also scoured the Internetz for any answers. I didn't ask anyone specifically though.

I did ask the question in the Slack #ui channel, but got no response. I also scoured the Internetz for any answers. I didn't ask anyone specifically though.

I believe that is handled in the not matching FHIR regex test.

I believe that is handled in the not matching FHIR regex test.

This looks good, left one comment. Could we send the UI review question to Team Parrot where they might know how it works in Angular?

This looks good, left one comment. Could we send the UI review question to Team Parrot where they might know how it works in Angular?

What do we do if the length is longer than 64 characters?

What do we do if the length is longer than 64 characters?

Ticket created: https://openlmis.atlassian.net/browse/OLMIS-4270

Ticket created: https://openlmis.atlassian.net/browse/OLMIS-4270

I tried it and as you said increasing timeout didn't help, it shows generic alert right away, I would create a bug for it.

I tried it and as you said increasing timeout didn't help, it shows generic alert right away, I would create a bug for it.

I can take a look, it seems that we are doing similar things in many other places, it is strange that it does not work here

I can take a look, it seems that we are doing similar things in many other places, it is strange that it does not work here