openlmis-cce-ui / src / admin-cce

cce-upload.html

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 21 Jul 17
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 23 Aug 2017
9:46 am

Mateusz Kwiatkowski

Monday 31 Jul 2017
9:02 am

Nikodem Graczewski

9:00 am

Nikodem Graczewski

Why are those commented out?

Why are those commented out?

Thursday 27 Jul 2017
6:11 pm

Nick Reid

6:11 pm

Nick Reid

use `is-empty` to be more SMACSS-y??

use `is-empty` to be more SMACSS-y??

Wednesday 26 Jul 2017
11:22 pm

Nick Reid

oh ha! no we are talking past eachother here http://getbootstrap.com/css/#helper-classes-screen-readers http://webaim.org/techniques/css/invisiblecontent/ @extend .sr-only;

oh ha! no we are talking past eachother here
http://getbootstrap.com/css/#helper-classes-screen-readers
http://webaim.org/techniques/css/invisiblecontent/ 

@extend .sr-only;
11:09 pm

Nick Reid

Seems to work great!

Seems to work great!

2:46 pm

Mateusz Kwiatkowski

Nick Reid I've just add required to this input and everything seems to work..... at least I guess so

Nick Reid I've just add required to this input and everything seems to work..... at least I guess so

2:33 pm

Mateusz Kwiatkowski

Nick Reid the problem is that attribute is already set to "file". Is there a way to set this regardless?

Nick Reid the problem is that attribute is already set to "file". Is there a way to set this regardless?

Tuesday 25 Jul 2017
6:41 pm

Nick Reid

These improvements look good

These improvements look good

6:35 pm

Nick Reid

how about just `.file-upload` or `.openlmis-file-upload` ??

how about just `.file-upload` or `.openlmis-file-upload` ??

Monday 24 Jul 2017
8:34 am

Mateusz Kwiatkowski

I've seen someone styling label and hiding input so probably it is a normal behaviour

I've seen someone styling label and hiding input so probably it is a normal behaviour

8:32 am

Mateusz Kwiatkowski

Shit, didn't realize that it was empty....... so stupid.......

Shit, didn't realize that it was empty....... so stupid.......

Sunday 23 Jul 2017
9:50 pm

Nick Reid

I'm surprised that clicking on the label will open the file input... is this how HTML normally works?

I'm surprised that clicking on the label will open the file input... is this how HTML normally works?

9:44 pm

Nick Reid

thanks for doing this!

thanks for doing this!

9:44 pm

Nick Reid

So, it seems like as of right now... if I tried to make a file input required by following our normal pattern, this wouldn't actually work... I'd like to be able to write: `<input id="foo" type="f...

So, it seems like as of right now... if I tried to make a file input required by following our normal pattern, this wouldn't actually work...

I'd like to be able to write: `<input id="foo" type="file" ng-model="example" required />`

I think a good way to accomplish this (with out rewritting ng-model required and other controllers that don't work here.... would be to add a text input into the directive, which is actually linked to ng-model... and the rest of this controller actually wraps (using parsers/formatters and validators)

9:39 pm

Nick Reid

... see above comment for set validity....

... see above comment for set validity....

9:33 pm

Nick Reid

What is this supposed to do? This sets the error key '' to null I think you want to ngModelController.$setValidity('openlmisFileUpload.wrongFileExtention', true);

What is this supposed to do? This sets the error key '' to null

I think you want to

ngModelController.$setValidity('openlmisFileUpload.wrongFileExtention', true);
9:29 pm

Nick Reid

Wrap these selectors as child selectors so they don't show up in unintended places!

Wrap these selectors as child selectors so they don't show up in unintended places!

9:29 pm

Nick Reid

it will be more maintainable to set 'align-items: baseline' (or flex end) on the parent

it will be more maintainable to set 'align-items: baseline' (or flex end) on the parent

9:28 pm

Nick Reid

For screen readers, this should be hidden, not `display:none`

For screen readers, this should be hidden, not `display:none`

9:26 pm

Nick Reid

Do we really need a class here? couldn't this just be a child selector?

Do we really need a class here? couldn't this just be a child selector?

9:23 pm

Nick Reid

If there is a selected file, lets change the message to "change file" — also, this button can hide the actual text by using "icon only"

If there is a selected file, lets change the message to "change file" — also, this button can hide the actual text by using "icon only"

Friday 21 Jul 2017
3:11 pm

Mateusz Kwiatkowski

OLMIS-2817: renamed admin cce module

Options
    • -5
    • +0
    ./cce-upload.html
  2. … 14 more files in changeset.
2:05 pm

Nikodem Graczewski

Mateusz Kwiatkowski Yeah

Mateusz Kwiatkowski Yeah

10:51 am

Mateusz Kwiatkowski

Don't you think that select button should be always visible and the clear button only if file is selected?

Don't you think that select button should be always visible and the clear button only if file is selected?

10:30 am

Mateusz Kwiatkowski

No, it's already fixed, it's just leftover from older commit.

No, it's already fixed, it's just leftover from older commit.

9:20 am

Mateusz Kwiatkowski

Nikodem Graczewski So just rename the module to 'admin-cce-upload'?

Nikodem Graczewski So just rename the module to 'admin-cce-upload'?

9:12 am

Nikodem Graczewski

We should probably add some tests here... https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/sad.gif

We should probably add some tests here...

9:09 am

Nikodem Graczewski

Me neither, but the thing is those types don't really work well with the directive. https://review.openlmis.org/static/ql0uca/2static/images/wiki/icons/emoticons/sad.gif

Me neither, but the thing is those types don't really work well with the directive.