Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
We should be adding new update in changelog after the last entry, so please change this

We should be adding new update in changelog after the last entry, so please change this

OLMIS-6484: Fixed 'The page size is not specified' error for /inventoryItems endpoints
OLMIS-6484: Fixed 'The page size is not specified' error for /inventoryItems endpoints
OLMIS-6484: Fixed 'The page size is not specified' error for /inventoryItems endpoints

    • -2
    • +7
    ./facility-cce-status/cce-inventory-item.service.decorator.js
    • -5
    • +5
    ./facility-cce-status/cce-inventory-item.service.decorator.spec.js
  1. … 1 more file in changeset.
Revert "OLMIS-6484 - Fixed 'The page size is not specified' error for /inventoryItems endpoints"

This reverts commit 53572604df91f38d1bae062acfe72b7914698550.

    • -7
    • +2
    ./facility-cce-status/cce-inventory-item.service.decorator.js
    • -10
    • +5
    ./facility-cce-status/cce-inventory-item.service.decorator.spec.js
  1. … 1 more file in changeset.
OLMIS-6484 - Fixed 'The page size is not specified' error for /inventoryItems endpoints

    • -2
    • +7
    ./facility-cce-status/cce-inventory-item.service.decorator.js
    • -5
    • +10
    ./facility-cce-status/cce-inventory-item.service.decorator.spec.js
  1. … 1 more file in changeset.
We decided on standup that the current version is correct

We decided on standup that the current version is correct

Nikodem Graczewski Klaudia Pałkowska Should we treat those changes are breaking changes?

Nikodem Graczewski Klaudia Pałkowska Should we treat those changes are breaking changes?

OLMIS-3176: Removed openlmis-testing-utils module.
OLMIS-3176: Removed openlmis-testing-utils module.
OLMIS-3176: Removed openlmis-testing-utils module.

    • -250
    • +0
    ./cce-inventory-item-details/inventory-item-details.html.spec.js
    • -30
    • +0
    ./openlmis-testing-utils/openlmis-testing-utils.module.js
    • -145
    • +0
    ./openlmis-testing-utils/template-testing-utils.factory.spec.js
  1. … 1 more file in changeset.
Done.

Done.

What about chained function calls, like moment.tz().format()?

What about chained function calls, like moment.tz().format()?

Something like this: https://github.com/OpenLMIS/openlmis-ui-components/blob/master/src/openlmis-function-decorator/openlmis-function-decorator.spec.js
Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Great, thanks!

Great, thanks!

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

https://openlmis.atlassian.net/browse/OLMIS-6170

https://openlmis.atlassian.net/browse/OLMIS-6170

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

Also changed the currency filter in ui-components to use the new localeService.

Also changed the currency filter in ui-components to use the new localeService.

Done.

Done.

Reduced the duplication.

Reduced the duplication.