Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
We decided on standup that the current version is correct

We decided on standup that the current version is correct

Nikodem Graczewski Klaudia Pałkowska Should we treat those changes are breaking changes?

Nikodem Graczewski Klaudia Pałkowska Should we treat those changes are breaking changes?

OLMIS-3176: Removed openlmis-testing-utils module.
OLMIS-3176: Removed openlmis-testing-utils module.
OLMIS-3176: Removed openlmis-testing-utils module.

    • -250
    • +0
    ./cce-inventory-item-details/inventory-item-details.html.spec.js
    • -30
    • +0
    ./openlmis-testing-utils/openlmis-testing-utils.module.js
    • -145
    • +0
    ./openlmis-testing-utils/template-testing-utils.factory.spec.js
  1. … 1 more file in changeset.
Done.

Done.

What about chained function calls, like moment.tz().format()?

What about chained function calls, like moment.tz().format()?

Something like this: https://github.com/OpenLMIS/openlmis-ui-components/blob/master/src/openlmis-function-decorator/openlmis-function-decorator.spec.js
Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Can you point to some other code as an example? I had a hard enough time trying to get this test to work properly.

Great, thanks!

Great, thanks!

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Yeah, that's perfectly correct. CurrencyService is a quite old one when we still were struggling with figuring out the promises.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

Please rewrite this so it doesn't use $provide. Those utilities should be injected in the inject blocked and spied on.

https://openlmis.atlassian.net/browse/OLMIS-6170

https://openlmis.atlassian.net/browse/OLMIS-6170

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

If we want to do this work, let's put it in another ticket, so this ticket doesn't drag on and not finish by the end of this sprint.

Also changed the currency filter in ui-components to use the new localeService.

Also changed the currency filter in ui-components to use the new localeService.

Done.

Done.

Reduced the duplication.

Reduced the duplication.

Done. Hopefully this is correct. Otherwise, I'm not sure how to go about implementing this.

Done. Hopefully this is correct. Otherwise, I'm not sure how to go about implementing this.

Then how do we catch in the locale cache code to call getLocaleSettingsFromConfig? Is there a good code example that shows this? I basically copied this from currency service.

Then how do we catch in the locale cache code to call getLocaleSettingsFromConfig? Is there a good code example that shows this? I basically copied this from currency service.

The whole datepicker format is confusing to me as well. Does it need to be different from the date format? And where is the documentation about its meaning, vs. the date formats?

The whole datepicker format is confusing to me as well. Does it need to be different from the date format? And where is the documentation about its meaning, vs. the date formats?

It may be a non-issue, as it looks like anything that would use datepicker would probably use business dates, which does not represent an instant in time, and so timezone would not be important. Ad...

It may be a non-issue, as it looks like anything that would use datepicker would probably use business dates, which does not represent an instant in time, and so timezone would not be important. Additionally, the datepicker directive does use the openlmis date filter.

I agree that it uses separate format, but what I'm concerned about is that the ticket might not pass the QA because of the second point of the acceptance criteria as the date picker will show diffe...

I agree that it uses separate format, but what I'm concerned about is that the ticket might not pass the QA because of the second point of the acceptance criteria as the date picker will show different date format (most likely one without timezone).

Yes but the datepicker format is a separate setting, and not in the reference data. I suppose we could add it, but it wasn't done in the other tickets, so this ticket just followed what was done.

Yes but the datepicker format is a separate setting, and not in the reference data. I suppose we could add it, but it wasn't done in the other tickets, so this ticket just followed what was done.

I see. Isn't the purpose of this ticket to make all components use the locales from the reference data?

I see. Isn't the purpose of this ticket to make all components use the locales from the reference data?

Alright, I'll try to do the extra checking in the localeService.

Alright, I'll try to do the extra checking in the localeService.