openlmis-cce-ui

package.json

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 01 Oct 18
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 05 Oct 2018
12:53 pm

Nikodem Graczewski

Wednesday 03 Oct 2018
5:25 am

Nikodem Graczewski

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. T...

What really is important are the changes in the dev-ui repository and package.json in the rest (which is repeated across all other modules), npm-shrinkwrap.json and yarn.lock files are generated. The change we're introducing here is locking dev-ui dependencies, which are no longer fetched to the node_modules in the root directory, but instead, are fetched into node_modules/dev-ui/node_modules. What we're doing is moving them to the node_modules directory so they are available to the module that is relying on dev-ui, lack of them there would break the build process because of missing dependencies. For yarn.lock we're basically copying the one generated in the .tmp directory, which is where we're firing yarn up during the build process. If you have any concern, please let me know.

Tuesday 02 Oct 2018
10:44 pm

Chongsun Ahn

10:44 pm

Chongsun Ahn

These changes are virtually impossible to review in-depth.

These changes are virtually impossible to review in-depth.

5:18 am

Nikodem Graczewski

It is.

It is.

5:16 am

Nikodem Graczewski

I've just moved it, it was already reviewed.

I've just moved it, it was already reviewed.

Monday 01 Oct 2018
1:44 pm

Mateusz Kwiatkowski and Łukasz Lewczyński

1:27 pm

Mateusz Kwiatkowski

I don't think we need to specifically say we've increased dependent service version, please remove this.

I don't think we need to specifically say we've increased dependent service version, please remove this.

1:26 pm

Mateusz Kwiatkowski

Is version correct here?

Is version correct here?

1:09 pm

Nikodem Graczewski

dev-ui version update has a separate review - FEOLMIS-3344.

dev-ui version update has a separate review - FEOLMIS-3344.

1:08 pm

Nikodem Graczewski

Not really, the release process stays the same. The only difference is that at some point we will have to update those dependencies so they don't go outdated.

Not really, the release process stays the same. The only difference is that at some point we will have to update those dependencies so they don't go outdated.

8:38 am

Mateusz Kwiatkowski

Do we need any documentation? Something needs to be changed in release process?

Do we need any documentation? Something needs to be changed in release process?

8:29 am

Łukasz Lewczyński

missing changelogs?

missing changelogs?

7:55 am

Nikodem Graczewski

OLMIS-3696: Added dependency locking
OLMIS-3696: Added dependency locking
7:10 am

Nikodem Graczewski <ngraczewski@soldevelo.com>

OLMIS-3696: Added .npmrc, npm-shrinkwrap.json, yarn.lock files and postinstall script

Options
    • -0
    • +3
    /package.json
  2. … 3 more files in changeset.
Tuesday 11 Jul 2017
2:07 pm

Paweł Nawrocki

1:57 pm

Mateusz Kwiatkowski

LGTM

LGTM

1:56 pm

Mateusz Kwiatkowski

1:31 pm

Paweł Nawrocki

Updated

Updated

1:27 pm

Paweł Nawrocki

Updated service version in package.json

Options
    • -1
    • +1
    /package.json
1:19 pm

Mateusz Kwiatkowski

please update version also here

please update version also here

1:11 pm

Paweł Nawrocki

Mateusz Kwiatkowski Updated

Mateusz Kwiatkowski Updated

12:51 pm

Paweł Nawrocki

Yes, otherwise styleguide generation task fails.

Yes, otherwise styleguide generation task fails.

12:50 pm

Mateusz Kwiatkowski

Shouldn't we add this repo to refderence-ui?

Shouldn't we add this repo to refderence-ui?

12:50 pm

Mateusz Kwiatkowski

should be marked as beta also

should be marked as beta also

12:49 pm

Mateusz Kwiatkowski

Maybe you could add cce-url.factory.js file?

Maybe you could add cce-url.factory.js file?

12:47 pm

Mateusz Kwiatkowski

Is css file also required?

Is css file also required?

11:52 am

Paweł Nawrocki

Nikodem Graczewski Mateusz Kwiatkowski I had to add those example classes for cce module, since otherwise it wouldn't build (karma fails when there's no unit tests, kss fails when there's no docume...

Nikodem Graczewski Mateusz Kwiatkowski I had to add those example classes for cce module, since otherwise it wouldn't build (karma fails when there's no unit tests, kss fails when there's no documentation, etc.)

11:51 am

Paweł Nawrocki

Create OpenLMIS CCE UI
Create OpenLMIS CCE UI
11:12 am

Paweł Nawrocki

Updated build files, added sample code to pass build

Options
    • -0
    • +7
    /package.json
  2. … 8 more files in changeset.