openlmis-cce-ui

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-3174: Remove unnecessary labels.

OLMIS-3174: Remove obsolete reasonNotWorkingOrNotInUse values

OLMIS-4197 Put button on its own line

Based on code review feedback. It makes more sense since in the view, the button is on a separate line.

OLMIS-4197 Add view alert history to CCE update functionality status

This adds a button to show the view alert history PDF.

OLMIS-4105 Define CCE alert default locale in controller

Instead of replacing hyphen with underscore for locale, just define it in the controller. This avoids any incorrect manipulation of the model.

    • -14
    • +0
    /src/cce-alert/cce-alert.factory.js
    • -30
    • +0
    /src/cce-alert/cce-alert.factory.spec.js
OLMIS-2895: Removed trailing comma

OLMIS-2895: Added missed reasonForNotWorking

OLMIS-2895: Added missing reasonForNotWorking

OLMIS-4129 Fix minor issues from code review feedback

    • -5
    • +5
    /src/cce-alert/cce-alert.factory.spec.js
Fix sonar quality issues

Tech debt/code smells.

    • -1
    • +1
    /src/cce-alert/cce-alert-repository.js
OLMIS-4105 Fix UI getting status message

The UI needs to look for the locale key that is a correct locale string. The approach here is done by replacing hyphens that come from the APIs, with underscores that match what the HTML is expecting. This is done because it is unclear how to use Angular interpolation with JavaScript object bracket notation ({{ obj['key'] }})?

    • -1
    • +16
    /src/cce-alert/cce-alert.factory.js
    • -1
    • +32
    /src/cce-alert/cce-alert.factory.spec.js
OLMIS-2895: Fixed console errors

OLMIS-3174: Update the FUNCTIONAL_STATUS and REASON_FOR_NOT_WORKING enums

OLMIS-3174: Fix failing case.

OLMIS-4129 Add button to dismiss alerts

The only issue here is that the alert service does not seem to pop up when the save fails.

OLMIS-4129 Add saving an alert to CCE alert factory

Even though this code is just a pass-through for the repository, it seems worth doing in case this part might be reused in a different context.

    • -1
    • +1
    /src/cce-alert/cce-alert-data-builder.js
    • -1
    • +20
    /src/cce-alert/cce-alert.factory.js
    • -1
    • +37
    /src/cce-alert/cce-alert.factory.spec.js
OLMIS-2895: fixed broken routes for cce inventory list screen

OLMIS-2895: drop then-catch part of checking user permissions

OLMIS-2895: removed relation to referencedata-user

OLMIS-2895: move variable assignment to onInit

OLMIS-2895: update jsdocs

OLMIS-2895: removed unused user variable

OLMIS-2895: Removed unnecessary lists from CceInventoryListController

OLMIS-3174: Update labels

OLMIS-2895: Extended filter options on CCE Inventory screen

    • -2
    • +2
    /src/cce-inventory-list/messages_en.json
OLMIS-4125 Add message for only inactive alerts

Show RTM Alerts section if only inactive alerts, with a message indicating there are no active alerts.

OLMIS-4125 Minor code changes from code review

* Remove factory, as method already exists in functional status constant.

* Use constant method instead.

* Create hasActiveAlerts helper function.

OLMIS-4125 Change function call to factory out of controller

Make controller code leaner and do DRY.

OLMIS-4125 Add popover with CCE inventory items

Add popover for facility's CCE status, showing each inventory item's status and any CCE alert icons. A new factory created for a helper method.

Also add logic to show an overall alert icon next to the facility's CCE status.

    • -1
    • +2
    /src/facility-cce-status/messages_en.json
OLMIS-4127 Use date filter on start_ts

For status update modal.