Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
added

added

do we test this?

do we test this?

Can we also check message here or there is no point in doing that?

Can we also check message here or there is no point in doing that?

thanks that we get error message from the notification service on UI instead of generic message

thanks that we get error message from the notification service on UI instead of generic message

no changelog entry because this is a regression

no changelog entry because this is a regression

OLMIS-5790: fixed issue with sending reset password email
OLMIS-5790: fixed issue with sending reset password email
OLMIS-5790: Improved handling 400 error from notification service

Instead of sending a general error message, the auth service should

present an error message from the notification service if the

notification service returns a response with 400 (BAD REQUEST)

status code.

    • -1
    • +12
    ./notification/NotificationServiceTest.java
  1. … 2 more files in changeset.
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style

fixed LICENCE header

fixed import order

fixed minor code style issues

added missing periods in javadocs

    • -3
    • +3
    ./ConfigurationSettingServiceTest.java
    • -10
    • +8
    ./consul/ConsulCommunicationServiceTest.java
    • -3
    • +3
    ./notification/EmailDetailsDtoTest.java
    • -3
    • +3
    ./notification/NotificationDtoTest.java
    • -3
    • +3
    ./notification/NotificationServiceTest.java
    • -3
    • +3
    ./notification/UserContactDetailsDtoTest.java
    • -1
    • +1
    ./notification/UserContactDetailsNotificationServiceTest.java
  1. … 147 more files in changeset.
Yes, I'm wondering what is better. I remember reading about always using exists if posibble, even if you have to retrieve whole object in some Performance Guidance or something in read the docs.

Yes, I'm wondering what is better. I remember reading about always using exists if posibble, even if you have to retrieve whole object in some Performance Guidance or something in read the docs.

moved

moved

OLMIS-4986: moved private methods back to user service

  1. … 2 more files in changeset.
but I still need it if it exists

but I still need it if it exists

Yes

Yes

We could use exists here to not get whole object first.

We could use exists here to not get whole object first.

This fix is applied to changes made after latest release?

This fix is applied to changes made after latest release?

I feel like this part should be in service and tested with unit tests

I feel like this part should be in service and tested with unit tests

OLMIS-4986: Fixed problem with saving auth user
OLMIS-4986: Fixed problem with saving auth user
OLMIS-4986: Fixed problem with saving auth user

  1. … 4 more files in changeset.
OLMIS-4986: Changed the user resource structure
OLMIS-4986: Changed the user resource structure
moved to user contact details notification service because there are email addresses

moved to user contact details notification service because there are email addresses