Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert "Revert Auth service back to Spring Boot 1.x"

This reverts commit d7de12a691485f3412f0342932693ed406151186.

  1. … 40 more files in changeset.
Revert Auth service back to Spring Boot 1.x

To see if it is the cause of the Superset issue.

  1. … 40 more files in changeset.
OLMIS-6761 Upgrade Spring Boot to 2.2.2
OLMIS-6761 Upgrade Spring Boot to 2.2.2
OLMIS-6761 Update Spring Boot version to 2.x

Using Boot version 2.2.2, as it is relatively recent.

* Flyway is at 6.0.8, new mechanism for loading Spring Security for OAuth2, and new versions for REST Assured, RAML tester, RAML parser, PowerMock (so tests will pass).

* Spring application properties for Flyway has changed.

* Fix repository method signatures (findOne is now findById, etc.); additionally they return Optional.

* Spring Security 5 has changed encoding of password storage to DelegatingPasswordEncoder. To be backwards-compatible, currently returning NoOpPasswordEncoder as default. Will probably need to migrate all passwords to new encoding and use a better encoder/decoder.

* Fix unit tests.

* Flyway is now at v6, and Java callback mechanism has changed to a general handle() method.

* Fix integration tests (including simplifying TokenIntegrationTest).

* Integration tests allow bean definition overriding, as it is not enabled by default now in Spring Boot 2.x.

* API definitions require "Keep-Alive" header for web integration tests.

  1. … 30 more files in changeset.
added

added

do we test this?

do we test this?

Can we also check message here or there is no point in doing that?

Can we also check message here or there is no point in doing that?

thanks that we get error message from the notification service on UI instead of generic message

thanks that we get error message from the notification service on UI instead of generic message

no changelog entry because this is a regression

no changelog entry because this is a regression

OLMIS-5790: fixed issue with sending reset password email
OLMIS-5790: fixed issue with sending reset password email
OLMIS-5790: Improved handling 400 error from notification service

Instead of sending a general error message, the auth service should

present an error message from the notification service if the

notification service returns a response with 400 (BAD REQUEST)

status code.

    • -1
    • +12
    ./notification/NotificationServiceTest.java
  1. … 2 more files in changeset.
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style

fixed LICENCE header

fixed import order

fixed minor code style issues

added missing periods in javadocs

    • -3
    • +3
    ./ConfigurationSettingServiceTest.java
    • -10
    • +8
    ./consul/ConsulCommunicationServiceTest.java
    • -3
    • +3
    ./notification/EmailDetailsDtoTest.java
    • -3
    • +3
    ./notification/NotificationDtoTest.java
    • -3
    • +3
    ./notification/NotificationServiceTest.java
    • -3
    • +3
    ./notification/UserContactDetailsDtoTest.java
    • -1
    • +1
    ./notification/UserContactDetailsNotificationServiceTest.java
  1. … 147 more files in changeset.
Yes, I'm wondering what is better. I remember reading about always using exists if posibble, even if you have to retrieve whole object in some Performance Guidance or something in read the docs.

Yes, I'm wondering what is better. I remember reading about always using exists if posibble, even if you have to retrieve whole object in some Performance Guidance or something in read the docs.

moved

moved

OLMIS-4986: moved private methods back to user service

  1. … 2 more files in changeset.
but I still need it if it exists

but I still need it if it exists

Yes

Yes

We could use exists here to not get whole object first.

We could use exists here to not get whole object first.

This fix is applied to changes made after latest release?

This fix is applied to changes made after latest release?