Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style

fixed LICENCE header

fixed import order

fixed minor code style issues

added missing periods in javadocs

  1. … 157 more files in changeset.
Yes, I'm wondering what is better. I remember reading about always using exists if posibble, even if you have to retrieve whole object in some Performance Guidance or something in read the docs.

Yes, I'm wondering what is better. I remember reading about always using exists if posibble, even if you have to retrieve whole object in some Performance Guidance or something in read the docs.

moved

moved

OLMIS-4986: added missing unit tests

  1. … 2 more files in changeset.
but I still need it if it exists

but I still need it if it exists

Yes

Yes

We could use exists here to not get whole object first.

We could use exists here to not get whole object first.

This fix is applied to changes made after latest release?

This fix is applied to changes made after latest release?

I feel like this part should be in service and tested with unit tests

I feel like this part should be in service and tested with unit tests

OLMIS-4986: Fixed problem with saving auth user
OLMIS-4986: Fixed problem with saving auth user
OLMIS-4986: Changed the user resource structure
OLMIS-4986: Changed the user resource structure
moved to user contact details notification service because there are email addresses

moved to user contact details notification service because there are email addresses

we don't do that here meme

we don't do that here meme

OLMIS-4986: Changed the user resource structure

    • -0
    • +85
    ./ConditionalUuidGeneratorTest.java
  1. … 26 more files in changeset.
I thought I removed the entry but not so I did it now https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

I thought I removed the entry but not so I did it now

Does this change require some modifications in CHANGELOG?

Does this change require some modifications in CHANGELOG?

OLMIS-4907: moved verification feature to notification service (auth service)
OLMIS-4907: moved verification feature to notification service (auth service)
OLMIS-4907: moved verification feature to notification service

  1. … 19 more files in changeset.