Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6548: Translate user password reset error modal

OLMIS-6548: Move PasswordResetRequest class to auth service and add password reset validator.

Move class to auth service

Replace to use PasswordResetRequest from auth service

Add validator for new Password

Add keys in messages to provide translations via transifex.

    • -0
    • +38
    ./org/openlmis/auth/dto/PasswordResetRequestDtoTest.java
    • -1
    • +12
    ./org/openlmis/auth/i18n/MessageKeysTest.java
    • -0
    • +130
    ./org/openlmis/auth/web/PasswordResetRequestDtoValidatorTest.java
  1. … 8 more files in changeset.
OLMIS-6548 Rename static field PASSWORD to PASS_FIELD. (SONAR ISSUE)

  1. … 1 more file in changeset.
OLMIS-6548 Rename class to PasswordResetRequestDtoValidator and add code review related changes.

    • -0
    • +38
    ./org/openlmis/auth/dto/PasswordResetRequestDtoTest.java
    • -0
    • +130
    ./org/openlmis/auth/web/PasswordResetRequestDtoValidatorTest.java
  1. … 8 more files in changeset.
OLMIS-6548 Move PasswordResetRequest class to auth service and add password reset validator.

Move class to auth service

Replace to use PasswordResetRequest from auth service

Add validator for new Password

Add keys in messages to provide translations via transifex.

    • -1
    • +12
    ./org/openlmis/auth/i18n/MessageKeysTest.java
    • -0
    • +130
    ./org/openlmis/auth/web/PasswordResetRequestValidatorTest.java
  1. … 7 more files in changeset.
OLMIS-6408: Added pageable validator
OLMIS-6408: Added pageable validator
OLMIS-6408: Added pageable validator

  1. … 6 more files in changeset.
done

done

OLMIS-6317: Added missing tests

    • -0
    • +123
    ./org/openlmis/auth/security/CustomTokenServicesTest.java
I would suggest to create separate, meaningful functions to get rid of comments (at least for first lambda).

I would suggest to create separate, meaningful functions to get rid of comments (at least for first lambda).

OLMIS-6317: Service account tokens will not expire
OLMIS-6317: Service account tokens will not expire
OLMIS-6317: Service account tokens will not expire

    • -0
    • +1
    ./org/openlmis/auth/ApiKeyInitializerTest.java
  1. … 5 more files in changeset.
added

added

do we test this?

do we test this?

Can we also check message here or there is no point in doing that?

Can we also check message here or there is no point in doing that?

thanks that we get error message from the notification service on UI instead of generic message

thanks that we get error message from the notification service on UI instead of generic message

no changelog entry because this is a regression

no changelog entry because this is a regression

OLMIS-5790: fixed issue with sending reset password email
OLMIS-5790: fixed issue with sending reset password email
OLMIS-5790: Improved handling 400 error from notification service

Instead of sending a general error message, the auth service should

present an error message from the notification service if the

notification service returns a response with 400 (BAD REQUEST)

status code.

  1. … 2 more files in changeset.
OLMIS-5668: Removed login restricted from the User model
OLMIS-5668: Removed login restricted from the User model
OLMIS-5668: Removed loginRestricted flag from the UserMainDetailsDto class

  1. … 2 more files in changeset.