20180607110415124__added_email_verification_tokens.sql

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I thought I removed the entry but not so I did it now https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

I thought I removed the entry but not so I did it now

Does this change require some modifications in CHANGELOG?

Does this change require some modifications in CHANGELOG?

OLMIS-4907: moved verification feature to notification service (auth service)
OLMIS-4907: moved verification feature to notification service (auth service)
OLMIS-4907: moved verification feature to notification service

    • -12
    • +0
    ./20180607110415124__added_email_verification_tokens.sql
  1. … 19 more files in changeset.
OLMIS-4833: Merge migrations

    • -0
    • +2
    ./20180607110415124__added_email_verification_tokens.sql
  1. … 1 more file in changeset.
I made some changes becuase of comments in this review and this part of code has been visible. Please left comment in FEOLMIS-3020

I made some changes becuase of comments in this review and this part of code has been visible. Please left comment in FEOLMIS-3020

How come? :O

How come? :O

maybe but this part of code is out of this review https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

maybe but this part of code is out of this review

Shouldn't this be called canSendVerificationEmail?

Shouldn't this be called canSendVerificationEmail?

from FEOLMIS-3020
from FEOLMIS-3020
from FEOLMIS-3020
changed

changed

added

added

do we test this?

do we test this?

I don't think so

I don't think so

could this be just GetMapping?

could this be just GetMapping?

I'm wondering if we should return some message here, do we do it on resetPassword?

I'm wondering if we should return some message here, do we do it on resetPassword?

That's why I sent an email to our dev group: https://groups.google.com/d/msg/openlmis-dev/fx6tI-HitK4/59i_7Ui7BAAJ
I'm not sure about placing this logic in auth service since email resides in referencedata.....

I'm not sure about placing this logic in auth service since email resides in referencedata.....

this change (private -> public) is related with FEOLMIS-3020

this change (private -> public) is related with FEOLMIS-3020

changed

changed

We should at least name these shouldBeExpired and shouldNotBeExpired. If we wanted to be clear, we would name it something like isExpiredShouldReturnTrueIfExpired and isExpiredShouldReturnFalseIfNo...

We should at least name these shouldBeExpired and shouldNotBeExpired. If we wanted to be clear, we would name it something like isExpiredShouldReturnTrueIfExpired and isExpiredShouldReturnFalseIfNotExpired.

OLMIS-4833: Added Email verification functionality for new users
OLMIS-4833: Added Email verification functionality for new users