Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style

fixed LICENCE header

fixed import order

fixed minor code style issues

added missing periods in javadocs

  1. … 157 more files in changeset.
I thought I removed the entry but not so I did it now https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

I thought I removed the entry but not so I did it now

Does this change require some modifications in CHANGELOG?

Does this change require some modifications in CHANGELOG?

OLMIS-4907: moved verification feature to notification service (auth service)
OLMIS-4907: moved verification feature to notification service (auth service)
OLMIS-4907: moved verification feature to notification service

    • -23
    • +0
    ./EmailVerificationTokenRepository.java
  1. … 19 more files in changeset.
I put it in methods

I put it in methods

added

added

changed

changed

This, and request.getEmail() could be hasEmailAddress and getEmailAddress, to be more clear.

This, and request.getEmail() could be hasEmailAddress and getEmailAddress, to be more clear.

It would be more clear if these were named something like referenceDataUserToSave and existingReferenceDataUser.

It would be more clear if these were named something like referenceDataUserToSave and existingReferenceDataUser.

Something like sendEmailVerificationNotificationIfNotVerified would be the most clear. Either that, or just not put it in a method. That way, the reader sees a notification is send if there is an e...

Something like sendEmailVerificationNotificationIfNotVerified would be the most clear. Either that, or just not put it in a method. That way, the reader sees a notification is send if there is an email address and it is not verified.

Alright, sounds good.

Alright, sounds good.

Until we verify a new email addres the user has to have old one in the property because other services use it to send notification. We could (and probably should) handle this better when all contra...

Until we verify a new email addres the user has to have old one in the property because other services use it to send notification. We could (and probably should) handle this better when all contract details will be in the notification service

added logging

added logging

I removed referenceDataUserId from the auth's user class and made that user instances in both services have the same ID field. Thanks that I don't have to wait for response from the reference data ...

I removed referenceDataUserId from the auth's user class and made that user instances in both services have the same ID field. Thanks that I don't have to wait for response from the reference data and I could put this statement to the end of user save process

moved to user class

moved to user class

renamed

renamed

changed

changed

changed

changed

changed

changed

We avoid if statement for save and update requests. Also we have to handle email update for update requests

We avoid if statement for save and update requests. Also we have to handle email update for update requests