Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6761 Remove unnecessary code

Removing migration integration test and some code previously used for another test.

  1. … 4 more files in changeset.
OLMIS-6761 Update Spring Boot version to 2.x

Using Boot version 2.2.2, as it is relatively recent.

* Flyway is at 6.0.8, new mechanism for loading Spring Security for OAuth2, and new versions for REST Assured, RAML tester, RAML parser, PowerMock (so tests will pass).

* Spring application properties for Flyway has changed.

* Fix repository method signatures (findOne is now findById, etc.); additionally they return Optional.

* Spring Security 5 has changed encoding of password storage to DelegatingPasswordEncoder. To be backwards-compatible, currently returning NoOpPasswordEncoder as default. Will probably need to migrate all passwords to new encoding and use a better encoder/decoder.

* Fix unit tests.

* Flyway is now at v6, and Java callback mechanism has changed to a general handle() method.

* Fix integration tests (including simplifying TokenIntegrationTest).

* Integration tests allow bean definition overriding, as it is not enabled by default now in Spring Boot 2.x.

* API definitions require "Keep-Alive" header for web integration tests.

    • -20
    • +30
    ./auth/ExportSchemaFlywayCallback.java
    • -2
    • +7
    ./auth/security/SecurityConfiguration.java
    • -1
    • +1
    ./auth/util/CustomSortDeserializer.java
    • -1
    • +1
    ./auth/web/CustomWebMvcConfigurerAdapter.java
  1. … 21 more files in changeset.
OLMIS-6558: Introduce new env variable - PUBLIC_URL

    • -2
    • +12
    ./auth/service/PasswordResetNotifier.java
  1. … 3 more files in changeset.
OLMIS-6548: Fix messages keys in passwordReset endpoint

OLMIS-6558 Add publicUrl variable to application properties and use it in generated links.

    • -2
    • +12
    ./auth/service/PasswordResetNotifier.java
  1. … 3 more files in changeset.
OLMIS-6548 Fix the messageKey issue in /passwordReset endpoint.

OLMIS-6548: Translate user password reset error modal

OLMIS-6548: Move PasswordResetRequest class to auth service and add password reset validator.

Move class to auth service

Replace to use PasswordResetRequest from auth service

Add validator for new Password

Add keys in messages to provide translations via transifex.

    • -0
    • +38
    ./auth/dto/PasswordResetRequestDto.java
    • -0
    • +59
    ./auth/web/PasswordResetRequestDtoValidator.java
  1. … 7 more files in changeset.
OLMIS-6548 Rename static field PASSWORD to PASS_FIELD. (SONAR ISSUE)

    • -5
    • +5
    ./auth/web/PasswordResetRequestDtoValidator.java
  1. … 1 more file in changeset.
OLMIS-6548 Rename class to PasswordResetRequestDtoValidator and add code review related changes.

    • -0
    • +38
    ./auth/dto/PasswordResetRequestDto.java
    • -34
    • +0
    ./auth/util/PasswordResetRequest.java
    • -0
    • +59
    ./auth/web/PasswordResetRequestDtoValidator.java
    • -56
    • +0
    ./auth/web/PasswordResetRequestValidator.java
  1. … 6 more files in changeset.
OLMIS-6548 Move PasswordResetRequest class to auth service and add password reset validator.

Move class to auth service

Replace to use PasswordResetRequest from auth service

Add validator for new Password

Add keys in messages to provide translations via transifex.

    • -0
    • +34
    ./auth/util/PasswordResetRequest.java
    • -0
    • +56
    ./auth/web/PasswordResetRequestValidator.java
  1. … 5 more files in changeset.
OLMIS-6408: Added pageable validator
OLMIS-6408: Added pageable validator
OLMIS-6408: Changed method name for pageable validator

    • -2
    • +2
    ./auth/interceptor/MvcInterceptor.java
OLMIS-6408: Added pageable validator

    • -0
    • +75
    ./auth/interceptor/MvcInterceptor.java
    • -0
    • +26
    ./auth/interceptor/PageableRequestContext.java
    • -0
    • +8
    ./auth/web/CustomWebMvcConfigurerAdapter.java
  1. … 3 more files in changeset.
done

done

OLMIS-6317: Created more meaningful methods to avoid comments (FEOLMIS-3835)

    • -4
    • +10
    ./auth/security/CustomTokenServices.java
I would suggest to create separate, meaningful functions to get rid of comments (at least for first lambda).

I would suggest to create separate, meaningful functions to get rid of comments (at least for first lambda).

OLMIS-6317: Service account tokens will not expire
OLMIS-6317: Service account tokens will not expire
OLMIS-6317: Service account tokens will not expire

    • -7
    • +17
    ./auth/security/CustomTokenServices.java
  1. … 5 more files in changeset.
Due to ACC, i have changed maximum page size to following sevices: *auth *cce *fulfillment *report *notification Requisition, stock, service-template had been changed before I started working o...

Due to ACC, i have changed maximum page size to following sevices:

  • auth
  • cce
  • fulfillment
  • report
  • notification


Requisition, stock, service-template had been changed before I started working on this ticket.

I have tested it with our open-lmis demo data.

OLMIS-4128 Change maximum page size to max integer.
OLMIS-4128 Change maximum page size to max integer.
OLMIS-4128 Change maximum page size to max integer.

    • -0
    • +16
    ./auth/web/CustomWebMvcConfigurerAdapter.java
  1. … 2 more files in changeset.