Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
OLMIS-6548 Add missing integration test for UserController.

    • -1
    • +22
    ./web/UserControllerIntegrationTest.java
OLMIS-6548: Translate user password reset error modal

OLMIS-6548: Move PasswordResetRequest class to auth service and add password reset validator.

Move class to auth service

Replace to use PasswordResetRequest from auth service

Add validator for new Password

Add keys in messages to provide translations via transifex.

    • -35
    • +13
    ./web/UserControllerIntegrationTest.java
  1. … 10 more files in changeset.
OLMIS-6548 Rename class to PasswordResetRequestDtoValidator and add code review related changes.

    • -7
    • +7
    ./web/UserControllerIntegrationTest.java
  1. … 10 more files in changeset.
OLMIS-6548 Move PasswordResetRequest class to auth service and add password reset validator.

Move class to auth service

Replace to use PasswordResetRequest from auth service

Add validator for new Password

Add keys in messages to provide translations via transifex.

    • -31
    • +9
    ./web/UserControllerIntegrationTest.java
  1. … 8 more files in changeset.
done

done

I would suggest to create separate, meaningful functions to get rid of comments (at least for first lambda).

I would suggest to create separate, meaningful functions to get rid of comments (at least for first lambda).

OLMIS-6317: Service account tokens will not expire
OLMIS-6317: Service account tokens will not expire
OLMIS-6317: Service account tokens will not expire

    • -1
    • +3
    ./web/UserControllerIntegrationTest.java
  1. … 3 more files in changeset.
OLMIS-5668: Added endpoint to get user by id
OLMIS-5668: Added endpoint to get user by id
OLMIS-5668: Added endpoint to get user by id

    • -0
    • +58
    ./web/UserControllerIntegrationTest.java
  1. … 3 more files in changeset.
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style
OLMIS-4295: updated checkstyle to new google style

fixed LICENCE header

fixed import order

fixed minor code style issues

added missing periods in javadocs

    • -3
    • +3
    ./ExposedMessageSourceIntegrationTest.java
    • -3
    • +3
    ./migration/BaseMigrationIntegrationTest.java
    • -3
    • +3
    ./migration/RemoveReferenceDataUserIdFromUserMigrationIntegrationTest.java
    • -5
    • +4
    ./repository/ApiKeyRepositoryIntegrationTest.java
    • -6
    • +5
    ./repository/BaseCrudRepositoryIntegrationTest.java
    • -3
    • +3
    ./repository/UserRepositoryIntegrationTest.java
    • -9
    • +6
    ./web/ApiKeyControllerIntegrationTest.java
  1. … 152 more files in changeset.
migration was introduced after 3.3 so yea no changelog entry here https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/wink.gif

migration was introduced after 3.3 so yea no changelog entry here

copy paste from reference data

copy paste from reference data

OLMIS-5062: Fixed broken migration
OLMIS-5062: Fixed broken migration
OLMIS-5062: Fixed broken migration

    • -0
    • +171
    ./migration/BaseMigrationIntegrationTest.java
    • -0
    • +103
    ./migration/RemoveReferenceDataUserIdFromUserMigrationIntegrationTest.java
  1. … 3 more files in changeset.
Yes, I'm wondering what is better. I remember reading about always using exists if posibble, even if you have to retrieve whole object in some Performance Guidance or something in read the docs.

Yes, I'm wondering what is better. I remember reading about always using exists if posibble, even if you have to retrieve whole object in some Performance Guidance or something in read the docs.

moved

moved