Dashboard

Those values were not provided with my changes so I don't know why we they are different

Those values were not provided with my changes so I don't know why we they are different

Shouldn't they be the same?

Shouldn't they be the same?

$padding or something like this.

$padding or something like this.

Yeah, but does it really matter?

Yeah, but does it really matter?

We use select2 on user roles screen and on that screen everything works fine so I am not sure if this change should be moved directly to select2 css

We use select2 on user roles screen and on that screen everything works fine so I am not sure if this change should be moved directly to select2 css

Then we get different values from the original

Then we get different values from the original

what kind of variable? what name should be used?

what kind of variable? what name should be used?

because of different values for padding-right property

because of different values for padding-right property

I was thinking of just adding this css direct to select2 without referencing openlmis-facility-program-select

I was thinking of just adding this css direct to select2 without referencing openlmis-facility-program-select

Why is 2,5 em used in one but 1 em in the other?

Why is 2,5 em used in one but 1 em in the other?

Could we use some variable here?

Could we use some variable here?

Could we round them up?

Could we round them up?

done

done

OLMIS-5488: converted px values to em values

LGTM

LGTM

Yes.

Yes.

OLMIS-5616: added description for what should be covered by which type of tests
OLMIS-5616: added description for what should be covered by which type of tests
If you feel it is okay to have two entries with the same ticket, feel free to resolve the comment

If you feel it is okay to have two entries with the same ticket, feel free to resolve the comment

I don't see changes in other features that used the old version of this step

I don't see changes in other features that used the old version of this step

so should I change value of $sidebar-width from px to em?

so should I change value of $sidebar-width from px to em?

OLMIS-5616: added description for what should be covered by which type of tests

Looking good Łukasz Lewczyński, left a couple comments. Thanks.

Looking good Łukasz Lewczyński, left a couple comments. Thanks.

Is this important? I don't see that bearer token in the steps so I'm confused where that one came from?

Is this important? I don't see that bearer token in the steps so I'm confused where that one came from?