Dashboard

Bump eslint from 4.11.0 to 4.18.2

Bumps [eslint](https://github.com/eslint/eslint) from 4.11.0 to 4.18.2.

- [Release notes](https://github.com/eslint/eslint/releases)

- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)

- [Commits](https://github.com/eslint/eslint/compare/v4.11.0...v4.18.2)

Signed-off-by: dependabot[bot] <support@github.com>

Bump ecstatic from 2.2.1 to 2.2.2

Bumps [ecstatic](https://github.com/jfhbrook/node-ecstatic) from 2.2.1 to 2.2.2.

- [Release notes](https://github.com/jfhbrook/node-ecstatic/releases)

- [Changelog](https://github.com/jfhbrook/node-ecstatic/blob/2.2.2/CHANGELOG.md)

- [Commits](https://github.com/jfhbrook/node-ecstatic/compare/2.2.1...2.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

Bump yarn from 1.12.3 to 1.17.3

Bumps [yarn](https://github.com/yarnpkg/yarn) from 1.12.3 to 1.17.3.

- [Release notes](https://github.com/yarnpkg/yarn/releases)

- [Changelog](https://github.com/yarnpkg/yarn/blob/v1.17.3/CHANGELOG.md)

- [Commits](https://github.com/yarnpkg/yarn/compare/v1.12.3...v1.17.3)

Signed-off-by: dependabot[bot] <support@github.com>

Bump mixin-deep from 1.3.1 to 1.3.2

Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.

- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)

- [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)

Signed-off-by: dependabot[bot] <support@github.com>

OLMIS-6613: Added pause before changing page on requisition view to make sure that changes are saved in cache

Added new property for long scenario duration in performance tests

    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
OLMIS-6118: Added requisition line items data for testing purposes

    • -2
    • +2
    /data/requisition.requisition_line_items.csv
OLMIS-6566: Updated changelog

OLMIS-6566: Updated test duration for getting 9000 FTAPs and searching orderables by version identities

    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
Modified thresholds for performance tests

* FTAPs and Orderables are more restrictive now

* All Supply Lines with Expand is a little less restrictive

    • -1
    • +1
    /performance/tests/approvedProductsForEssentialMedsAndDistrictHospital.yml
All right. Did something in that manner. Thanks https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

All right. Did something in that manner. Thanks

OLMIS-6671: Introduced an additional method for better readibility

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that https://review...

You could extract checks for column names to the first method, and then use this method + other two checks in the second method and use it in the if statement. Or something like that

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Well... That's true, too. I was even looking into this matter before :/ I removed this unnecessary method.

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one...

Did some refactoring. I extracted this into separate private method, dividing as I left seemed logically - sourcetype & if a column is displayed and what is it's name (that should be treated as one thing I think). Could not extract it all into a separate method as Sonar wasn't allowing this.

OLMIS-6671: Refactored the method in attempt to fix Sonar errors

OLMIS-6611: Removed unnecessary method

Why do we need a method that only calls another method? https://review.openlmis.org/static/ogdo0b/2static/images/wiki/icons/emoticons/smile.gif

Why do we need a method that only calls another method?

True. The method was refactored.

True. The method was refactored.

OLMIS-6671: Refactored methods

OLMIS-6611: Refactored a method

To improve readability we could: 1. merge this with an already existing if-statement 2. Extract this check to a separate private method

To improve readability we could:
1. merge this with an already existing if-statement
2. Extract this check to a separate private method