1. The review is quite big because for all new classes I had to add tests to avoid sonar issues. But the main changes are in the service package when a bunch of new classes has been created based o...
1. The review is quite big because for all new classes I had to add tests to avoid sonar issues. But the main changes are in the service package when a bunch of new classes has been created based on the diagram in the ticket. Also because of comments from the previous versions of the review I had to provide additional changes. 2. Each component of spring integration has two channels: input and output. Only start and end of flow has one channel: output and input, respectively. Everything starts in NotificationToSendRetriever and ends in EmailNotificationChannelHandler. As I said before it is easier to see what happens when you open the diagram from the ticket.
In the end, I am not sure if there is an easy way to remove unnecessary changes. If you still have an issue to understand changes you could try to do this together with the diagram from the ticket.
1. The size of this review is too large and unfocused. It's difficult to grasp what is supposed to be evident and what's a WIP. Next time try much smaller reviews chained together that build upon one another. Less than a dozen files, no more than 1k LOC.
2. It's not really clear what's happening in the service layer with regards to what should be a filter, what's a router, and where we'd see an aggregator. This is likely a continuation of the above.